Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: optimize AnimatedList component #334

Merged
merged 2 commits into from
Nov 15, 2024

Conversation

gokh4nozturk
Copy link
Contributor

Fix: Animated List

Pulled from issues: #333

Copy link

vercel bot commented Sep 24, 2024

@gokh4nozturk is attempting to deploy a commit to the product-studio Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Collaborator

@itsarghyadas itsarghyadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So what it does basically - stop the animation after all the items are shown? @gokh4nozturk

@gokh4nozturk
Copy link
Contributor Author

So what it does basically - stop the animation after all the items are shown?

Yes @itsarghyadas

@itsarghyadas
Copy link
Collaborator

@gokh4nozturk thanks for the reply. So if I’m understanding correctly, after displaying all the notifications for a set time, the animation just stops until you refresh the page. Is that correct?

Also, could you explain how this optimizes the functionality and what specific error you saw, as mentioned in the issue #333

@itsarghyadas
Copy link
Collaborator

Why do you think the animation stopping when the number of elements runs out is expected? Just trying to understand your perspective.

@itsarghyadas
Copy link
Collaborator

We discussed this internally, and I’ve reviewed it. This PR is good to go. Thanks for the contribution!

@itsarghyadas itsarghyadas merged commit 7d6daa4 into magicuidesign:main Nov 15, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants