Avoid stealing touches from other native modals. #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With `react-native-navigation`, an overlay with `interceptTouchesOutside=false` is not allowed to pass through the touches because of the wrapper view introduces by `react-native-root-siblings`. As I've seen in the issues section in `react-native-navigation`, many people ditch libraries like `react-native-popup-dialog` and `react-native-root-toast` due to this issue.
|
@magicismight This is an important one :-) |
|
Care for a release? :-) |
|
@danielgindi I remember I already published? |
|
Oh yes. Seems like you have published to npm but no commit/tag here with the version, so I got confused. Sorry! |
|
@danielgindi Sorry not that formal 🤣 |
micheleb
added a commit
to urbi-mobility/react-native-formik
that referenced
this pull request
Apr 28, 2020
Include this PR that fixes touch events on react-native-navigation overlays: magicismight/react-native-root-siblings#47
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
react-native-navigation, an overlay withinterceptTouchesOutside=falseis not allowed to pass through the touches because of the wrapper view introduces byreact-native-root-siblings.As I've seen in the issues section in
react-native-navigation, many people ditch libraries likereact-native-popup-dialogandreact-native-root-toastdue to this issue.