-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Permissions implementation #23
base: master
Are you sure you want to change the base?
Permissions implementation #23
Conversation
We may also need some command line flags to turn on/off the type of methods supported by the server? |
Codecov ReportBase: 97.10% // Head: 96.74% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #23 +/- ##
==========================================
- Coverage 97.10% 96.74% -0.36%
==========================================
Files 8 9 +1
Lines 829 923 +94
Branches 154 161 +7
==========================================
+ Hits 805 893 +88
- Misses 16 18 +2
- Partials 8 12 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
61f6008
to
02707c7
Compare
17bece3
to
3da60ab
Compare
Locally, there's 1 uncovered line. Don't know what codecov is doing... |
7ac741a
to
6617587
Compare
Further to the "multiple permissions method" thread and #30 and options-wise, what probably makes sense is:
Separately, I'd also like to add "external" permissions so operators can play with non-standard ones. That is, "anything that implements Not sure precisely how to handle merging etc -- and maybe we want at least the options interface to work like #30 says... |
This PR now also fixes #30 |
WIP: this is a proof-of-concept implementation of the "permissions" spec, implementing the "none" and "hashcash" methods.
Needs: