Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve/build android #163

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Improve/build android #163

wants to merge 3 commits into from

Conversation

pleszkiewicz
Copy link
Contributor

Add build script for Android.
The script uses "manual" build commands (gradlew). For some reason, react-native run-android and magic-script build android stopped working.

build_android.sh Outdated
# ./gradlew assembleRelease
cd ../../

say -v Melina 'android build done'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this only works on mac right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right, only on mac

echo "4. verifying cache..."
npm cache verify

say -v Melina "clean cache done"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here, this won't work on Linux/WIndows

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only mac

Copy link
Member

@kpiascik kpiascik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since say only works on Mac we should make sure this script works on Linux.

@pleszkiewicz
Copy link
Contributor Author

pleszkiewicz commented Nov 26, 2020

@pleszkiewicz
Copy link
Contributor Author

This should work on MacOS and Linux (still need to check on Linux):

tell() {
  case "$OSTYPE" in
    darwin*)  say -v Melina "$1" ;; 
    linux*)   echo "$1" | espeak ;;
    *)        echo "$1" ;;
  esac
}

tell 'android build done'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants