-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve/build android #163
base: develop
Are you sure you want to change the base?
Conversation
build_android.sh
Outdated
# ./gradlew assembleRelease | ||
cd ../../ | ||
|
||
say -v Melina 'android build done' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this only works on mac right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right, only on mac
echo "4. verifying cache..." | ||
npm cache verify | ||
|
||
say -v Melina "clean cache done" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here, this won't work on Linux/WIndows
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only mac
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since say
only works on Mac we should make sure this script works on Linux.
How to do TTS on Linux:https://superuser.com/questions/93691/mac-os-x-say-command-in-ubuntu How to recognize OS from bash script:https://stackoverflow.com/questions/394230/how-to-detect-the-os-from-a-bash-script |
This should work on MacOS and Linux (still need to check on Linux):
|
Add build script for Android.
The script uses "manual" build commands (gradlew). For some reason,
react-native run-android
andmagic-script build android
stopped working.