Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

security-package: Update for reCaptcha.js - changes for include Google API js script #176

Conversation

engcom-Kilo
Copy link
Contributor

Description (*)

Updated reCaptcha.js,
the script - google.com/recaptcha/api.js will include only once time to HTML document.

To reCaptcha.js added checker with variable window.addedScriptTag

Fixed Issues (if relevant)

Manual testing scenarios (*)

  1. Add settings for reCaptcha v2 checkbox (api keys test/test)
  2. Add settings for reCaptcha v3 (api keys test/test)
  3. Enable reCaptcha for Contact page with reCaptcha v2 checkbox
  4. Enable reCaptcha for Newsletter form with reCaptcha v3
  5. Clean up the cache
  6. Open Contact page
  7. Check HTML source of page

Create_New_Customer_Account

Questions or comments

Contribution checklist (*)

  • Author has signed the Adobe CLA
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@engcom-Kilo engcom-Kilo added the Component: Google reCAPTCHA Issues and Pull Requests related to reCAPTCHA should be marked with this label label Apr 1, 2020
@engcom-Kilo
Copy link
Contributor Author

engcom-Kilo commented Apr 2, 2020

Related Pull Request
#183: security-package: Changes for include Google API js file - Admin panel

@engcom-Foxtrot
Copy link
Contributor

Please see #191.

@lenaorobei lenaorobei deleted the security-package/1time-include-google-api-js-script branch June 10, 2020 20:57
magento-devops-reposync-svc pushed a commit that referenced this pull request Nov 12, 2024
[Support Tier-4 abukatar] 10-31-2024 Regular delivery of bugfixes and improvements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Google reCAPTCHA Issues and Pull Requests related to reCAPTCHA should be marked with this label Progress: review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants