-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: Layered Navigation (Filters) #797
feature: Layered Navigation (Filters) #797
Conversation
Hello @soumya-ashok thank you for feedback. Regarding the filters not applying after changing, I'm not sure if the attribute filters input has been added to GraphQL backend. @jimbo , @sirugh feel free to let me know if I'm in the wrong. I've been checking out the Catalog GraphQL schema and didn't see the attribute filter input: https://github.com/magento/magento2/blob/2.3-develop/app/code/Magento/CatalogGraphQl/etc/schema.graphqls#L279 Regarding the style issues (full height filters modal and swatch width), they have been fixed in the latest update. Let me know if there is anything else that needs to be fixed. |
Thanks @codeAdrian fixes looks good. Waiting for @jimbo to provide review approval for recent commits. |
LogError: Error: Could not find a `dangerfile.js` or `dangerfile.ts` in the current working directory.
at Object.dangerfilePath (/codebuild/output/src451119981/src/github.com/magento-research/pwa-studio/node_modules/danger/distribution/commands/utils/fileUtils.js:26:11)
at Object.<anonymous> (/codebuild/output/src451119981/src/github.com/magento-research/pwa-studio/node_modules/danger/distribution/commands/danger-runner.js:92:42)
at step (/codebuild/output/src451119981/src/github.com/magento-research/pwa-studio/node_modules/danger/distribution/commands/danger-runner.js:33:23)
at Object.next (/codebuild/output/src451119981/src/github.com/magento-research/pwa-studio/node_modules/danger/distribution/commands/danger-runner.js:14:53)
at fulfilled (/codebuild/output/src451119981/src/github.com/magento-research/pwa-studio/node_modules/danger/distribution/commands/danger-runner.js:5:58)
at process._tickCallback (internal/process/next_tick.js:68:7)
|
Adrian Bece seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@codeAdrian Thanks for being so patient with us. This is in a great place now, and I'm happy to approve it.
When we're ready to hook this up to GraphQL, we'll have another opportunity to adjust the UX or presentation of the components, but I think this is ready to go. 👍
@codeAdrian I've resolved the conflicts that were created when we merged #1211, which converted |
@jimbo Thanks for resolving the conflicts. I really appreciate it. I have fixed a minor issue and cleaned up a commented-out piece of code that was leftover from the merge. I am happy to proceed with the merge on Monday. Cheers! |
Did another round of QA, all looks good. @jimbo - Good to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, this is good to go now.
I'd like to follow this up with a new PR to migrate the filter logic from Redux into a hook. @tjwiebell had successfully moved the pagination logic into a hook in #1211, which meant Category
no longer needed to be connected to Redux, but with this PR it's connected again. If we put the filter logic in a hook, we can once again remove that connection to Redux.
Description
When this PR is merged, it will:
Additional notes:
Related Issue
Closes #361
Motivation and Context
Adding Layered navigation to category page.
How Has This Been Tested?
Tested with Venia sample data on any product category.
Automatic tests will be added when general components and structure are approved.
Screenshots (if appropriate):
Proposed Labels for Change Type/Package
FEATURE
venia-concept
Checklist: