Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tailwind presets in main config file #4353

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

del22123
Copy link
Collaborator

Description

This PR contains the fix for tailwind css screen name (media query) issue when creating a new PWA theme.

Closes #PWA-3364
https://jira.corp.adobe.com/browse/PWA-3364

Acceptance

Verification Stakeholders

Specification

Verification Steps

Create a new theme as per the steps mentioned in official PWA documentation
https://developer.adobe.com/commerce/pwa-studio/guides/theming/#create-a-new-theme

Current result:
Error is thrown while running yarn build command

Fix result:
Yarn build will be successful and new theme will be created

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@pwa-studio-bot
Copy link
Collaborator

Fails
🚫 A version label is required. A maintainer must add one.
Messages
📖

Associated JIRA tickets: PWA-3364.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against 86ea0ee

@del22123 del22123 added the version: Minor This changeset includes functionality added in a backwards compatible manner. label Nov 18, 2024
@del22123 del22123 self-assigned this Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:venia-concept Progress: approved version: Minor This changeset includes functionality added in a backwards compatible manner.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants