-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed handleTriggerClick function call as it is not used #4351
base: develop
Are you sure you want to change the base?
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved
run pr-deploy |
Successfully started codebuild job for |
LogERROR ON TASK: cypressTests
|
LogERROR ON TASK: cypressTests
|
Description
This PR contains the fix for handleTriggerClick function call error in customer login flow when require email confirmation is enabled and or wrong password is given.
Closes #PWA-3381
https://jira.corp.adobe.com/browse/PWA-3381
Acceptance
Verification Stakeholders
Specification
Verification Steps
Step 1: Enable customer email confirmation from Magento Admin panel -> Stores -> Customer -> Customer Configuration -> Create New Account Options -> Require Emails Confirmation -> Yes and save the config
Step 2: In PWA store view add a product to cart and then go to Checkout page -> Sign In-> Create an account (or) Header -> Sign in -> Create an account
Step 3: Enter all the necessary details for the new customer account (Email should not exist already in the website)
Step 4: Click create an account button
Step 5: Once the user is created try to login to the newly created account
(This issue may happen even with existing account when wrong password is given while sign in)
Current result:
No error is thrown and account will not login
Fix result:
Existing generic error message will be shown
(An error has occurred. Please check the input and try again)
Screenshots / Screen Captures (if appropriate)
Breaking Changes (if any)
Checklist