Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PWA-3318::Prex compatibility #4349

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

PWA-3318::Prex compatibility #4349

wants to merge 8 commits into from

Conversation

glo82145
Copy link
Collaborator

@glo82145 glo82145 commented Nov 5, 2024

Description

We need to make sure all OOTB PREX function should work when installed along with PWA-Studio. To achieve same we need to check which all scenerios are working or not and once it all possible cases check done, we need to incorportae required missing functionality including frontend and Backend data analytics in respect of PWA-Studio Compatibility Scope.

https://developer.adobe.com/commerce/pwa-studio/integrations/product-recommendations/
https://experienceleague.adobe.com/en/docs/commerce-merchant-services/product-recommendations/getting-started/headless
https://experienceleague.adobe.com/en/docs/commerce-merchant-services/product-recommendations/getting-started/install-configure

Preconditions

None

Acceptance Criteria
PREX Extenstion along with BackendMetapackages should be compatible to use with magento
All PREX Front End Metapackages should be integrated in PWA-studio Repo in extenstion folder to directly install locally

Related Issue

Closes #PWA-3318

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@glo82145 glo82145 added the version: Minor This changeset includes functionality added in a backwards compatible manner. label Nov 5, 2024
@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Nov 5, 2024

Fails
🚫

node failed.

🚫

The following file(s) did not pass ESLint. Execute yarn run lint locally for more details

packages/extensions/venia-product-recommendations/lib/components/VeniaProductRecommendations/VeniaProductRecommendations.js
packages/extensions/venia-product-recommendations/lib/hooks/useObserver.js
packages/extensions/venia-product-recommendations/lib/hooks/useRecsTrackingProps.js
packages/extensions/venia-product-recommendations/lib/hooks/useSyncMSEToLocalStorage.js
packages/extensions/venia-product-recommendations/lib/queries/getCart.gql.js
packages/extensions/venia-product-recommendations/package.json
🚫

The following file(s) were not formatted with prettier. Make sure to execute yarn run prettier locally prior to committing.

packages/extensions/venia-product-recommendations/babel.config.js
packages/extensions/venia-product-recommendations/jest.config.js
packages/extensions/venia-product-recommendations/lib/components/Gallery/gallery.css
packages/extensions/venia-product-recommendations/lib/components/Gallery/Gallery.js
packages/extensions/venia-product-recommendations/lib/components/Gallery/item.css
packages/extensions/venia-product-recommendations/lib/components/VeniaProductRecommendations/ProductRecommendations.css
packages/extensions/venia-product-recommendations/lib/components/VeniaProductRecommendations/VeniaProductRecommendations.js
packages/extensions/venia-product-recommendations/lib/hooks/useObserver.js
packages/extensions/venia-product-recommendations/lib/hooks/useRecsData.js
packages/extensions/venia-product-recommendations/lib/hooks/useRecsTrackingProps.js
packages/extensions/venia-product-recommendations/lib/hooks/useSyncMSEToLocalStorage.js
packages/extensions/venia-product-recommendations/lib/index.js
packages/extensions/venia-product-recommendations/lib/queries/getCart.gql.js
packages/extensions/venia-product-recommendations/lib/targets/intercept.js
packages/extensions/venia-product-recommendations/lib/wrappers/wrapUseApp.js
packages/extensions/venia-product-recommendations/lib/wrappers/wrapUseGalleryItem.js
packages/extensions/venia-product-recommendations/test/mocks.js
packages/peregrine/lib/talons/Gallery/isSupportedProductType.js
packages/venia-ui/lib/components/Gallery/item.js
Messages
📖

Associated JIRA tickets: PWA-3318.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Log

ERROR ON TASK: prettierCheck


ERROR ON TASK: eslintCheck


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

Generated by 🚫 dangerJS against 0a3ab1f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:extensions pkg:peregrine pkg:venia-ui Progress: ready for review version: Minor This changeset includes functionality added in a backwards compatible manner.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants