Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PWA-3294 :PLP should displayed on all store view #4282

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

glo85315
Copy link
Contributor

Description

PLP should displayed on all store view.

Related Issue

https://jira.corp.adobe.com/browse/PWA-3294

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@pwa-studio-bot
Copy link
Collaborator

Fails
🚫

node failed.

🚫 A version label is required. A maintainer must add one.
🚫

Unable to build scaffolded project.

yarn build

within a scaffolded project directory failed.
Learn more about Scaffolding at https://magento.github.io/pwa-studio/pwa-buildpack/scaffolding/.

🚫

Unit tests in the following files did not pass 😔. All tests must pass before this PR can be merged

  • packages/peregrine/lib/targets/__tests__/peregrine-targets.spec.js
  • packages/pwa-buildpack/lib/Utilities/__tests__/configureHost.spec.js
  • packages/pwa-buildpack/lib/WebpackTools/plugins/__tests__/RootComponentsPlugin.spec.js
  • packages/pwa-buildpack/lib/WebpackTools/plugins/__tests__/LocalizationPlugin.spec.js
  • packages/venia-ui/lib/targets/__tests__/venia-ui-targets.spec.js
  • packages/pwa-buildpack/lib/WebpackTools/plugins/__tests__/UpwardIncludePlugin.spec.js
  • packages/venia-ui/lib/components/App/__tests__/localeProvider.spec.js
🚫

The following file(s) did not pass ESLint. Execute yarn run lint locally for more details

packages/venia-ui/lib/components/App/localeProvider.js
Messages
📖

Associated JIRA tickets: PWA-3294.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Log

ERROR ON TASK: eslintCheck


ERROR ON TASK: unitTests


ERROR ON TASK: scaffoldingSucceeds


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

Generated by 🚫 dangerJS against a92b95b

@@ -0,0 +1,410 @@
{
"About Us": "關於我們",
"Account": "帳戶",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We donot commit this file .. Please remove it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Changes Requested
Development

Successfully merging this pull request may close these issues.

3 participants