PWA-3154:GraphQL cacheable requests always have Authorization Bearer … #4240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glo11372
added
pkg:peregrine
version: Minor
|
glo82145
reviewed
Mar 15, 2024
| __esModule: true, | ||
| default: jest.fn(() => 'auth') | ||
| })); | ||
| // jest.mock('@magento/peregrine/lib/Apollo/links/authLink', () => ({ |
There was a problem hiding this comment.
Please donot comment line like these .. remove it from code
m2-community-project
bot
added
Progress: review
and removed
Progress: ready for review
labels
glo82145
reviewed
Mar 15, 2024
| @@ -1,6 +1,6 @@ | |||
| import { createHttpLink } from '@apollo/client'; | |||
|
|
|||
| import createAuthLink from '@magento/peregrine/lib/Apollo/links/authLink'; | |||
| // import createAuthLink from '@magento/peregrine/lib/Apollo/links/authLink'; | |||
glo82145
previously approved these changes
Mar 18, 2024
|
How will signed in customer functionality work with the authLink removed? |
please see attached screen shot .red mark
|
|
deploy pr-test |
|
deploy pwa-pr-test |
glo82145
approved these changes
Apr 1, 2024
glo82145
added a commit
that referenced
this pull request
Jun 5, 2024
#4240) * PWA-3154:GraphQL cacheable requests always have Authorization Bearer header * PWA-3154:Removing Commented lines * Update index.spec.js.snap * Update index.spec.js.snap --------- Co-authored-by: Aanchal Pawar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
GraphQL cacheable requests always have "Authorization Bearer" header
Steps to test the behaviour :
1- sign up.in Venia.magento.com or any PWA store
2- login
3- check network tab on any page and search for GraphQL requests which should be cached such as CMSPages
4- check the request header you will not find Authorization Bearer header exist
5- Varnish will cache that request's response.
Related Issue
Closes # https://jira.corp.adobe.com/browse/PWA-3154
Acceptance
Verification Stakeholders
Specification
Verification Steps
Test scenario(s) for direct fix/feature
Test scenario(s) for any existing impacted features/areas
Test scenario(s) for any Magento Backend Supported Configurations
Is Browser/Device testing needed?
Any ad-hoc/edge case scenarios that need to be considered?
Screenshots / Screen Captures (if appropriate)
Breaking Changes (if any)
Checklist