Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PWA-3182::Accessibility || screen reader reading wrong quantity into… #4172

Merged
merged 5 commits into from
Oct 4, 2023

Conversation

glo80771
Copy link
Contributor

… sub-folder of My account even when havnig atleast 1 item or more or zero

Description

Pre-Conditions:

  1. venia.magento.com for testing the accessibility scope
  2. Control navigation using tab button instead of mouse
  3. flow with registered user

Steps to Execute:

  1. use tab button and navigate till the login profile
  2. press enter to expand the login folder for username and password
  3. now keep pressing tab until system control is navigated on subfolders of Profile
  4. press Enter button and observe if reader is calculating the and speaking correct quantity of folder for first time instead reading as empty even when empty or having atleast one product in list

✖️ Actual Result:
Reader should speak correct quantity of folder

✔️ Expected Result:
screen reader reading wrong quantity into sub-folder of My account even when having atleast 1 item or more or zero

Related Issue

Closes https://jira.corp.adobe.com/browse/PWA-3182.

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

… sub-folder of My account even when havnig atleast 1 item or more or zero
@glo80771 glo80771 added the version: Patch This changeset includes backwards compatible bug fixes. label Sep 28, 2023
@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Sep 28, 2023

Messages
📖

Associated JIRA tickets: PWA-3182.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against 0f9363f

@glo80771 glo80771 changed the title PWA-3182::Accessibility || srcreen reader reading wrong quantity into… PWA-3182::Accessibility || screen reader reading wrong quantity into… Sep 28, 2023
@glo82145
Copy link
Collaborator

glo82145 commented Oct 4, 2023

run lighthouse-desktop

@pwa-test-bot
Copy link

pwa-test-bot bot commented Oct 4, 2023

Successfully started codebuild job for lighthouse-desktop

@glo82145
Copy link
Collaborator

glo82145 commented Oct 4, 2023

run lighthouse-mobile

@pwa-test-bot
Copy link

pwa-test-bot bot commented Oct 4, 2023

Successfully started codebuild job for lighthouse-mobile

@glo82145 glo82145 merged commit 457bd2f into develop Oct 4, 2023
1 check passed
@glo82145 glo82145 deleted the PWA-3182 branch December 1, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:venia-ui Progress: done version: Patch This changeset includes backwards compatible bug fixes.
Projects
Development

Successfully merging this pull request may close these issues.

4 participants