-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pwa 3139 v2 #4124
Pwa 3139 v2 #4124
Conversation
…in Magento , and is not required on normal storefront
|
…ll issue for credit card payment mode
…ll issue for credit card payment method
if (shippingAddress.region == null) { | ||
shippingAddress.region = ''; | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use null coalescing
? mapAddressData(shippingAddressData.cart.shippingAddresses[0]) | ||
: {}; | ||
|
||
if (shippingAddress.region == null) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use null coalescing
createErrorMessage?.includes(errorMessage) || | ||
updateErrorMessage?.includes(errorMessage); | ||
|
||
// errors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
irrelevant information
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check mentioned points
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check mentioned points
run lighthouse-desktop |
Successfully started codebuild job for |
run lighthouse-mobile |
Successfully started codebuild job for |
Description
Region is required in PWA although this option is disabled in Magento , and is not required on normal storefront .
A clear and concise description of what the bug is.
Steps to reproduce the behavior:
Set default country to United Kingdom , disable State is Required for UK .
Try to create order , in SHIPPING INFORMATION - state will be required ,
Related Issue
Closes https://jira.corp.adobe.com/browse/PWA-3139.
Acceptance
Verification Stakeholders
Specification
Verification Steps
Test scenario(s) for direct fix/feature
Test scenario(s) for any existing impacted features/areas
Test scenario(s) for any Magento Backend Supported Configurations
Is Browser/Device testing needed?
Any ad-hoc/edge case scenarios that need to be considered?
Screenshots / Screen Captures (if appropriate)
Breaking Changes (if any)
Checklist