Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pwa 3139 v2 #4124

Merged
merged 10 commits into from
Sep 29, 2023
Merged

Pwa 3139 v2 #4124

merged 10 commits into from
Sep 29, 2023

Conversation

glo80771
Copy link
Contributor

Description

Region is required in PWA although this option is disabled in Magento , and is not required on normal storefront .

A clear and concise description of what the bug is.

Steps to reproduce the behavior:
Set default country to United Kingdom , disable State is Required for UK .
Try to create order , in SHIPPING INFORMATION - state will be required ,

Related Issue

Closes https://jira.corp.adobe.com/browse/PWA-3139.

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented May 30, 2023

Messages
📖

Associated JIRA tickets: PWA-3139.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against 29c3b44

@glo80771 glo80771 added the version: Patch This changeset includes backwards compatible bug fixes. label May 30, 2023
if (shippingAddress.region == null) {
shippingAddress.region = '';
}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use null coalescing

? mapAddressData(shippingAddressData.cart.shippingAddresses[0])
: {};

if (shippingAddress.region == null) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use null coalescing

createErrorMessage?.includes(errorMessage) ||
updateErrorMessage?.includes(errorMessage);

// errors
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

irrelevant information

Copy link
Collaborator

@glo82145 glo82145 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check mentioned points

Copy link
Collaborator

@glo82145 glo82145 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check mentioned points

@glo82145
Copy link
Collaborator

run lighthouse-desktop

@pwa-test-bot
Copy link

pwa-test-bot bot commented Sep 29, 2023

Successfully started codebuild job for lighthouse-desktop

@glo82145
Copy link
Collaborator

run lighthouse-mobile

@pwa-test-bot
Copy link

pwa-test-bot bot commented Sep 29, 2023

Successfully started codebuild job for lighthouse-mobile

@glo82145 glo82145 merged commit 59ad6b7 into develop Sep 29, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:peregrine pkg:venia-ui Progress: done version: Patch This changeset includes backwards compatible bug fixes.
Projects
Development

Successfully merging this pull request may close these issues.

3 participants