Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pwa 3122 #4104

Merged
merged 8 commits into from
May 19, 2023
Merged

Pwa 3122 #4104

merged 8 commits into from
May 19, 2023

Conversation

glo80771
Copy link
Contributor

@glo80771 glo80771 commented Apr 26, 2023

Description

The system does not read the displayed success message/error message for accessible users if the User presses the Return Button with a blank Gift card number
Step to Reproduce

  1. Open the terminal and checkout branch of PWA-3111
  2. now Yarn install >> yarn watch >> yarn stage:venia / yarn watch:venia
  3. add one product to the cart and go to the cart
  4. now user tab to navigate to the gift card option and Apply using the Return button for invalid gift card number like an empty field or wrong card number
  5. observe if the system reads messages for valid/invalid gift card numbers or Empty field
    Expected Result
    The user should be able to speak the following messages in case of a valid/invalid gift card while pressing the return button
    use case 1:- If typed Valid Gift card number - You have applied gift card worth "currency xyz"(example – You have applied gift card worth 1 dollar)
    use case 2:- if Invalid Gift card number or blank field* – Invalid card. Please try again.
    Actual Result
    Use case 1: system applies for the card but does not read, how much amount worth coupon has been applied in case a valid gift card number
    Use case 2: The system does not read any message in case the gift card field is empty

Related Issue

Closes https://jira.corp.adobe.com/browse/PWA-3122

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Apr 26, 2023

Messages
📖

Associated JIRA tickets: PWA-3111.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against 750f8d5

@glo80771 glo80771 added the version: Patch This changeset includes backwards compatible bug fixes. label Apr 26, 2023
@glo82145 glo82145 self-requested a review May 4, 2023 06:56
@glo82145
Copy link
Collaborator

run lighthouse-mobile

@pwa-test-bot
Copy link

pwa-test-bot bot commented May 19, 2023

Successfully started codebuild job for lighthouse-mobile

@glo82145
Copy link
Collaborator

run lighthouse-desktop

@pwa-test-bot
Copy link

pwa-test-bot bot commented May 19, 2023

Successfully started codebuild job for lighthouse-desktop

@glo82145 glo82145 merged commit b51aadc into develop May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:peregrine pkg:venia-ui Progress: done version: Patch This changeset includes backwards compatible bug fixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants