Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PWA-3108-V1::When the button forget password is pressed, there's no m… #4092

Merged
merged 4 commits into from
May 23, 2023

Conversation

glo80771
Copy link
Contributor

…essage to convey the information that the content has been refreshed for screen reader users.

Description

When the button "forget password" is pressed, there's no message to convey the information that the content has been refreshed for screen reader users.

Related Issue

Closes https://jira.corp.adobe.com/browse/PWA-3108.

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

…essage to convey the information that the content has been refreshed for screen reader users.
@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Apr 18, 2023

Messages
📖

Associated JIRA tickets: PWA-3108.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against fbdffa7

@glo82145 glo82145 added the version: Patch This changeset includes backwards compatible bug fixes. label Apr 18, 2023
@glo82145 glo82145 self-requested a review April 18, 2023 10:27
glo82145
glo82145 previously approved these changes Apr 18, 2023
@glo82145
Copy link
Collaborator

run lighthouse-desktop

@pwa-test-bot
Copy link

pwa-test-bot bot commented Apr 20, 2023

Successfully started codebuild job for lighthouse-desktop

@glo82145
Copy link
Collaborator

run lighthouse-mobile

@pwa-test-bot
Copy link

pwa-test-bot bot commented Apr 20, 2023

Successfully started codebuild job for lighthouse-mobile

@glo82145
Copy link
Collaborator

run lighthouse-mobile

@pwa-test-bot
Copy link

pwa-test-bot bot commented May 23, 2023

Successfully started codebuild job for lighthouse-mobile

@glo82145
Copy link
Collaborator

run lighthouse-desktop

@pwa-test-bot
Copy link

pwa-test-bot bot commented May 23, 2023

Successfully started codebuild job for lighthouse-desktop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:peregrine pkg:venia-ui Progress: done version: Patch This changeset includes backwards compatible bug fixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants