Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetching and displaying errors when adding product to cart #4090

Merged

Conversation

justinconabree
Copy link
Contributor

Description

When adding a product to the cart, if there is an error (eg insufficient stock), the product fails to add to cart and there is no feedback to the user.

  • Adding user_errors to graphql response when adding products to cart
  • Adding graphql response errors to front-end errors

Related Issue

Closes #3953

Acceptance

Verification Stakeholders

Specification

No special verification

Verification Steps

Test scenario(s) for direct fix/feature

  1. Go to a product page
  2. Add 900 qty of the product to your cart
  3. Try to repeat the action of adding 900 to your cart
  4. There should be an error message displayed under the quantity saying there's insufficient stock

Test scenario(s) for any existing impacted features/areas

None

Test scenario(s) for any Magento Backend Supported Configurations

None

Is Browser/Device testing needed?

No

Any ad-hoc/edge case scenarios that need to be considered?

No

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

None

Checklist

  • [ ] I have added tests to cover my changes, if necessary.
  • [ ] I have added translations for new strings, if necessary.
  • [ ] I have updated the documentation accordingly, if necessary.

@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Apr 14, 2023

Messages
📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against 4074311

@glo82145 glo82145 added the version: Patch This changeset includes backwards compatible bug fixes. label Sep 8, 2023
@glo82145
Copy link
Collaborator

run lighthouse-desktop

@pwa-test-bot
Copy link

pwa-test-bot bot commented Sep 21, 2023

Successfully started codebuild job for lighthouse-desktop

@glo82145
Copy link
Collaborator

run lighthouse-mobile

@pwa-test-bot
Copy link

pwa-test-bot bot commented Sep 21, 2023

Successfully started codebuild job for lighthouse-mobile

@glo82145 glo82145 merged commit f8a44d3 into magento:develop Sep 21, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:peregrine Progress: done version: Patch This changeset includes backwards compatible bug fixes.
Projects
4 participants