Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PWA#3051 Update to latest @adobe/magento-storefront-event-collector #4086

Merged
merged 8 commits into from
May 23, 2023

Conversation

RaghavendraTirumalasetti
Copy link
Contributor

Description

Once the newest package is released for @adobe/magento-storefront-event-collector we will need to update our dependencies.

Related Issue

Closes #https://jira.corp.adobe.com/browse/PWA-3051

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Apr 13, 2023

Messages
📖

Associated JIRA tickets: PWA-3051.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against 96f0d44

aniham
aniham previously approved these changes Apr 13, 2023
glo82145
glo82145 previously approved these changes Apr 26, 2023
@glo82145 glo82145 added the version: Patch This changeset includes backwards compatible bug fixes. label Apr 26, 2023
@glo42707
Copy link
Contributor

run cypress

@pwa-test-bot
Copy link

pwa-test-bot bot commented May 12, 2023

Successfully started codebuild job for cypress

@pwa-studio-bot
Copy link
Collaborator

Fails
🚫

node failed.

🚫

Cypress tests in the following files did not pass 😔. All tests must pass before this PR can be merged

  • user should be able to navigate on offline mode:
    • AssertionError: Timed out retrying after 30000ms: expected '/vitalia-top' to include '/vitalia-top.html'
  • Verify venia anchor links:
    • AssertionError: Timed out retrying after 30000ms: expected 'https://pr-4086.pwa-venia.com/valeria-two-layer-tank' to include '/valeria-two-layer-tank.html'
  • user should be able to place an order as a registered customer:
    • CypressError: Timed out retrying after 60000ms: `cy.wait()` timed out waiting `60000ms` for the 1st request to the route: `gqlGetCustomerAfterCreateQuery`. No request ever occurred.

      https://on.cypress.io/wait

  • User shouldn't be able to add a CustomizableProduct from category page:
  • contains valid CMS Page data:,contains valid CMS Page data specific to the different store:
  • user should be able search with different inputs and view different suggestions:
    • AssertionError: Timed out retrying after 30000ms: expected '/vitalia-top' to include '/vitalia-top.html'
  • User shouldn't be able to add a CustomizableProduct from search:
  • verify products content type:
    • AssertionError: Timed out retrying after 30000ms: Expected to find element: .slick-slider, but never found it.

    verify category page:
    • AssertionError: Timed out retrying after 30000ms: Expected to find element: a[data-cy="GalleryItem-name"][href$="/carina-cardigan.html"], but never found it.

    verify search page:
    • AssertionError: Timed out retrying after 30000ms: Expected to find element: a[data-cy="GalleryItem-name"][href$="/selena-pants.html"], but never found it.
  • should be able to edit a configurable product and place an order:
    • AssertionError: Timed out retrying after 30000ms: Expected to find element: [data-cy="OrderConfirmationPage-root"] [data-cy="OrderConfirmationPage-header"], but never found it.
  • user should be able to add and remove products from wishlist:
    • CypressError: Timed out retrying after 60000ms: cy.wait() timed out waiting 60000ms for the 1st request to the route: gqlSignInAfterCreateMutation. No request ever occurred.

      https://on.cypress.io/wait

  • user should be able to add and remove promotions from cart:
    • AssertionError: Timed out retrying after 30000ms: Expected <span.discountSummary-discountLineItemLabel-LrJ.priceSummary-lineItemLabel-1Cs.justify-self-start.my-2.grid.grid-flow-col.items-center> not to exist in the DOM, but it was continuously found.
  • user should be able to place an order as a guest:
    • CypressError: Timed out retrying after 60000ms: cy.wait() timed out waiting 60000ms for the 1st request to the route: gqlGetItemsInCartQuery. No request ever occurred.

      https://on.cypress.io/wait

  • should be able to place an order in French store:
    • AssertionError: Timed out retrying after 30000ms: Expected to find element: [data-cy="ProductOptions-Option-root"], but never found it.

    should display English text and USD currency accross app if Default Store View is selected:
    • CypressError: Timed out retrying after 60000ms: cy.wait() timed out waiting 60000ms for the 1st request to the route: gqlSignInAfterCreateMutation. No request ever occurred.

      https://on.cypress.io/wait


    should display French text and EUR currency accross app if French Store View is selected:
    • AssertionError: Timed out retrying after 30000ms: Expected to find element: [data-cy="ProductFullDetail-root"] [data-cy="ProductOptions-Option-root"] [data-cy="ProductOptions-Option-selectedLabel"], but never found it.

    should show USD currency across app if it is selected inside French Store View:
    • AssertionError: Timed out retrying after 30000ms: Expected to find element: [data-cy="ProductFullDetail-root"] [data-cy="ProductFullDetail-productPrice"], but never found it.
  • user should be able to place an order as a guest with an specified Region and a credit card:
    • CypressError: Timed out retrying after 60000ms: cy.wait() timed out waiting 60000ms for the 1st request to the route: gqlGetCheckoutDetailsQuery. No request ever occurred.

      https://on.cypress.io/wait

Log

ERROR ON TASK: cypressTests


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

Generated by 🚫 dangerJS against 0d6596d

@pwa-studio-bot
Copy link
Collaborator

Fails
🚫

node failed.

🚫

Cypress tests in the following files did not pass 😔. All tests must pass before this PR can be merged

  • Verify content:
    • Error: Image size (1280x1869) different than saved snapshot size (1280x1658). See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/aboutUsPage/aboutUsPage.spec.js/__diff_output__/AboutUs.diff.png
  • Verify content:
    • Error: Image was 2.0008840289507224% different from saved snapshot with 52989.81191550777 different pixels. See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/customerService/customerService.spec.js/__diff_output__/Customer-Service-Page.diff.png
  • verify column content:
    • Error: Image was 7.658328706604878% different from saved snapshot with 753726.5846410868 different pixels. See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/column.spec.js/__diff_output__/Page-Builder-Column-Page.diff.png
    ,should apply mediaQuery styles:
    • Error: Image was 2.4061142240380584% different from saved snapshot with 48168.4818738627 different pixels. See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/column.spec.js/__diff_output__/Column-media-query-(Desktop).diff.png
  • verify divider content:
    • Error: Image was 20.94891106307312% different from saved snapshot with 1016541.7195534105 different pixels. See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/divider.spec.js/__diff_output__/Page-Builder-Divider-Page.diff.png
  • verify mocked google map api with two markers and click event:
    • Error: Image was 2.621848037935426% different from saved snapshot with 53024.25471920605 different pixels. See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/map.spec.js/__diff_output__/Page-Builder-Verify-Map---2-Locations.diff.png
  • verify dynamic block content:
    • Error: Image was 2.621848037935426% different from saved snapshot with 52487.30024103688 different pixels. See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/dynamicBlock.spec.js/__diff_output__/Page-Builder-Dynamic-Block-Snapshot.diff.png
  • verify slider content:
    • Error: Image was 2.621848037935426% different from saved snapshot with 52487.30024103688 different pixels. See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/slider.spec.js/__diff_output__/Page-Builder-Slider-Page.diff.png
    verify slider content 2:
    • Error: Image was 5.799802732530401% different from saved snapshot with 116107.41086307261 different pixels. See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/slider.spec.js/__diff_output__/Page-Builder-Slider-Page-2.diff.png
    verify slider content 3:
    • Error: Image was 16.88772507716221% different from saved snapshot with 338078.7458647257 different pixels. See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/slider.spec.js/__diff_output__/Page-Builder-Slider-Page-3.diff.png
    verify slider content 4:
    • Error: Image was 21.63970511525014% different from saved snapshot with 433209.58464321564 different pixels. See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/slider.spec.js/__diff_output__/Page-Builder-Slider-Page-4.diff.png
    verify slider content 5:
    • Error: Image was 21.577861648502793% different from saved snapshot with 431971.52791370713 different pixels. See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/slider.spec.js/__diff_output__/Page-Builder-Slider-Page-5.diff.png
    verify slider content 6:
    • Error: Image was 21.54520702443923% different from saved snapshot with 431317.8084636538 different pixels. See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/slider.spec.js/__diff_output__/Page-Builder-Slider-Page-6.diff.png
    verify slider content 7:
    • Error: Image was 1.0082792778816185% different from saved snapshot with 67949.95709499804 different pixels. See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/slider.spec.js/__diff_output__/Page-Builder-Slider-Page-7.diff.png
    verify slider content 8:
    • Error: Image was 1.582977776215655% different from saved snapshot with 55822.12830046886 different pixels. See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/slider.spec.js/__diff_output__/Page-Builder-Slider-Page-8.diff.png
    verify slider content 10:
    • Error: Image was 7.634317979555516% different from saved snapshot with 268630.27361021587 different pixels. See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/slider.spec.js/__diff_output__/Page-Builder-Slider-Page-10.diff.png
    verify slider content 11:
    • Error: Image was 4.796009316593796% different from saved snapshot with 379322.1320605833 different pixels. See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/slider.spec.js/__diff_output__/Page-Builder-Slider-Page-11.diff.png
    verify slider content 12:
    • Error: Image size (1280x5234) different than saved snapshot size (1280x5015). See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/slider.spec.js/__diff_output__/Page-Builder-Slider-Page-12.diff.png
    ,should apply mediaQuery styles:
    • Error: Image was 2.5673525716413015% different from saved snapshot with 53039.45024805197 different pixels. See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/slider.spec.js/__diff_output__/Slider-media-query-(Desktop).diff.png
  • verify banner content:
    • Error: Image was 2.054961975679115% different from saved snapshot with 52712.24063054011 different pixels. See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/banner.spec.js/__diff_output__/Page-Builder-Home-Page.diff.png
    verify banner content2:
    • Error: Image was 1.0415560698647575% different from saved snapshot with 53247.67927090997 different pixels. See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/banner.spec.js/__diff_output__/Page-Builder-Home-Page2.diff.png
    verify banner content3:
    • Error: Image was 1.0415560698647575% different from saved snapshot with 53247.67927090997 different pixels. See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/banner.spec.js/__diff_output__/Page-Builder-Home-Page3.diff.png
    verify banner content4:
    • Error: Image was 1.2068824301607495% different from saved snapshot with 53048.758594201776 different pixels. See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/banner.spec.js/__diff_output__/Page-Builder-Home-Page4.diff.png
    verify banner content7:
    • Error: Image was 1.0861941871446734% different from saved snapshot with 53193.970688198664 different pixels. See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/banner.spec.js/__diff_output__/Page-Builder-Home-Page7.diff.png
    verify banner content8:
    • Error: Image was 1.3339226859671482% different from saved snapshot with 53186.165334882135 different pixels. See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/banner.spec.js/__diff_output__/Page-Builder-Home-Page8.diff.png
    verify banner content9:
    • Error: Image was 1.1697475861558115% different from saved snapshot with 53422.84015877038 different pixels. See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/banner.spec.js/__diff_output__/Page-Builder-Home-Page9.diff.png
    verify banner content10:
    • Error: Image was 2.724720106600098% different from saved snapshot with 299030.4024830623 different pixels. See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/banner.spec.js/__diff_output__/Page-Builder-Home-Page10.diff.png
    ,should apply mediaQuery styles:
    • Error: Image was 1.551705981635254% different from saved snapshot with 52753.037916457404 different pixels. See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/banner.spec.js/__diff_output__/Banner-media-query-(Desktop).diff.png
  • verify smoke test content:
    • TypeError: The following error originated from your application code, not from Cypress.

      Failed to execute 'unobserve' on 'IntersectionObserver': parameter 1 is not of type 'Element'.

      When Cypress detects uncaught errors originating from your application it will automatically fail the current test.

      This behavior is configurable, and you can choose to turn this off by listening to the uncaught:exception event.

      https://on.cypress.io/uncaught-exception-from-application


    verify smoke test cms block content:
    • Error: Image was 1.2080820771527612% different from saved snapshot with 55730.27591754946 different pixels.
      See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/smokeTest.spec.js/diff_output/Page-Builder-Smoke-Test-CMS-Block-Content.diff.png

    verify smoke test dynamic block content:
    • Error: Image was 1.2080820771527612% different from saved snapshot with 55730.27591754946 different pixels.
      See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/smokeTest.spec.js/diff_output/Page-Builder-Smoke-Test-Dynamic-Block-Content.diff.png
  • verify block content:
    • Error: Image was 10.549816794183242% different from saved snapshot with 680049.6304064872 different pixels.
      See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/block.spec.js/diff_output/Page-Builder-Block-Page.diff.png

    verify block dynamic block content:
    • Error: Image was 1.6018530634484884% different from saved snapshot with 58353.5848777523 different pixels.
      See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/block.spec.js/diff_output/Page-Builder-Dynamic-Block.diff.png

    verify block cms block content:
    • Error: Image was 1.6018530634484884% different from saved snapshot with 58353.5848777523 different pixels.
      See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/block.spec.js/diff_output/Page-Builder-CMS-Block.diff.png

    verify block cms page content:
    • Error: Image was 1.4488963140331323% different from saved snapshot with 55377.97623939755 different pixels.
      See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/block.spec.js/diff_output/Page-Builder-CMS-Page.diff.png
  • verify tabs content:
    • Error: Image was 1.9494519752194184% different from saved snapshot with 345798.47004916094 different pixels.
      See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/tabs.spec.js/diff_output/Page-Builder-Tabs-Page.diff.png
    ,should apply mediaQuery styles:
    • Error: Image was 2.534453103337586% different from saved snapshot with 52359.77355247186 different pixels.
      See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/tabs.spec.js/diff_output/Tabs-media-query-(Desktop).diff.png
  • verify text content:
    • Error: Image size (1280x7419) different than saved snapshot size (1280x7453).
      See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/text.spec.js/diff_output/Page-Builder-Text-Page.diff.png
  • verify row content:
    • Error: Image was 32.489072635585195% different from saved snapshot with 5043967.513561764 different pixels.
      See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/row.spec.js/diff_output/Page-Builder-Row.diff.png

    verify row content2:
    • Error: Image was 8.715849362812767% different from saved snapshot with 1102687.4253061297 different pixels.
      See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/row.spec.js/diff_output/Page-Builder-Row2.diff.png

    verify row video background3:
    • CypressError: cy.visit() failed trying to load:

      https://pr-4086.pwa-venia.com/

      The response we received from your web server was:

      502: Bad Gateway

      This was considered a failure because the status code was not 2xx.

      If you do not want status codes to cause failures pass the option: failOnStatusCode: false

    ,should apply mediaQuery styles:
    • CypressError: cy.visit() failed trying to load:

      https://pr-4086.pwa-venia.com/

      The response we received from your web server was:

      502: Bad Gateway

      This was considered a failure because the status code was not 2xx.

      If you do not want status codes to cause failures pass the option: failOnStatusCode: false

Log

ERROR ON TASK: cypressTests


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

Generated by 🚫 dangerJS against 0d6596d

@glo82145
Copy link
Collaborator

run lighthouse-mobile

@pwa-test-bot
Copy link

pwa-test-bot bot commented May 17, 2023

Successfully started codebuild job for lighthouse-mobile

@glo82145
Copy link
Collaborator

run lighthouse-desktop

@pwa-test-bot
Copy link

pwa-test-bot bot commented May 17, 2023

Successfully started codebuild job for lighthouse-desktop

@glo82145
Copy link
Collaborator

ru lighthouse-desktop

@glo82145
Copy link
Collaborator

run lighthouse-mobile

@pwa-test-bot
Copy link

pwa-test-bot bot commented May 23, 2023

Successfully started codebuild job for lighthouse-mobile

@glo82145
Copy link
Collaborator

run lighthouse-desktop

@pwa-test-bot
Copy link

pwa-test-bot bot commented May 23, 2023

Successfully started codebuild job for lighthouse-desktop

@glo82145 glo82145 merged commit 0a815bf into magento:develop May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:extensions Progress: done version: Patch This changeset includes backwards compatible bug fixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants