Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Venia header/layout broken in offline mode #4075

Merged
merged 6 commits into from
May 15, 2023
Merged

Conversation

RaghavendraTirumalasetti
Copy link
Contributor

Description

Steps to Reproduce

Set device to offline mode
Got to venia.magento.com or develop.pwa-venia.com on mobile
Observe logo and action icons overlapping in header
Expected

Logo and action icons in header to do not overlap in offline mode

Actual

Header layout in Venia on mobile with offline mode is not wrapping correctly.

Related Issue

Closes #https://jira.corp.adobe.com/browse/PWA-2615.

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Mar 30, 2023

Messages
📖

Associated JIRA tickets: PWA-2615.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against 4420b4b

@RaghavendraTirumalasetti RaghavendraTirumalasetti added the version: Patch This changeset includes backwards compatible bug fixes. label Mar 30, 2023
@glo82145
Copy link
Collaborator

run lighthouse-desktop

@pwa-test-bot
Copy link

pwa-test-bot bot commented May 15, 2023

Successfully started codebuild job for lighthouse-desktop

@glo82145
Copy link
Collaborator

run lighthouse-mobile

@pwa-test-bot
Copy link

pwa-test-bot bot commented May 15, 2023

Successfully started codebuild job for lighthouse-mobile

@glo82145 glo82145 merged commit 879a25c into magento:develop May 15, 2023
@glo42707 glo42707 mentioned this pull request May 19, 2023
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:venia-ui Progress: done version: Patch This changeset includes backwards compatible bug fixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants