BUG#PWA 3057 Search auto populate results not accessible with tab or up/down keys. #4060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
glo82145
added
the
version: Patch
glo82145
approved these changes
Apr 26, 2023
m2-community-project
bot
added
Progress: approved
and removed
Progress: ready for review
labels
|
run lighthouse-mobile |
|
Successfully started codebuild job for |
|
run lighthouse-desktop |
|
Successfully started codebuild job for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The keyboard focus and tab order does not work as expected. When we try to access auto populated search results with tab or key up/down key, focus is not going to search results. Instead of search results focus is going to the main page.
Step to reproduce :
Goto https://venia.magento.com/
Click on search icon on home page
Search any keyword for example, "Night"
Once search result appears try to access search results by tab or up/down keys
Actual Result :
User is not able to access auto populated search results with tab or up/down keys
Expected Result :
User should able to access auto populated results with the tab or key/up down keys.
Related Issue
Closes #https://jira.corp.adobe.com/browse/PWA-3057.
Acceptance
Verification Stakeholders
Specification
Verification Steps
Test scenario(s) for direct fix/feature
Test scenario(s) for any existing impacted features/areas
Test scenario(s) for any Magento Backend Supported Configurations
Is Browser/Device testing needed?
Any ad-hoc/edge case scenarios that need to be considered?
Screenshots / Screen Captures (if appropriate)
Breaking Changes (if any)
Checklist