You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GET params (query part of the link) are missed in URL after clicked on the link
STEPS TO REPLICATE:
Install the latest Magento 2 ee
Install the latest PWA studio
Admin: Open the home page in the Page Builder editor and add HTML code with the link: adewfewf
Frontend: Open the home page in PWA venia
Click on the link
DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖
Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.
Cypress tests in the following files did not pass 😔. All tests must pass before this PR can be merged
user should be able to add and remove promotions from cart:
AssertionError: Timed out retrying after 30000ms: Expected not to exist in the DOM, but it was continuously found.
user should be able to update their address book:
CypressError: Timed out retrying after 60000ms: `cy.wait()` timed out waiting `60000ms` for the 1st request to the route: `gqlSignInAfterCreateMutation`. No request ever occurred.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ISSUE:
GET params (query part of the link) are missed in URL after clicked on the link
STEPS TO REPLICATE:
Install the latest Magento 2 ee
Install the latest PWA studio
Admin: Open the home page in the Page Builder editor and add HTML code with the link:
adewfewf
Frontend: Open the home page in PWA venia
Click on the link
EXPECTED RESULTS:
Page with GET param opened
ACTUAL RESULTS:{}
GET params are missed
Related Issue
Closes #PWA-3049
Acceptance
Verification Stakeholders
Specification
Verification Steps
Test scenario(s) for direct fix/feature
Test scenario(s) for any existing impacted features/areas
Test scenario(s) for any Magento Backend Supported Configurations
Is Browser/Device testing needed?
Any ad-hoc/edge case scenarios that need to be considered?
Screenshots / Screen Captures (if appropriate)
Breaking Changes (if any)
Checklist