Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PWA-3049::[PWA] Internal Page Builder links with query part #4059

Merged
merged 7 commits into from
Mar 23, 2023

Conversation

glo82145
Copy link
Collaborator

@glo82145 glo82145 commented Mar 14, 2023

Description

ISSUE: 

GET params (query part of the link) are missed in URL after clicked on the link

STEPS TO REPLICATE:

Install the latest Magento 2 ee
Install the latest PWA studio
Admin: Open the home page in the Page Builder editor and add HTML code with the link:
adewfewf

Frontend: Open the home page in PWA venia
Click on the link

EXPECTED RESULTS:

Page with GET param opened

ACTUAL RESULTS:{}

GET params are missed

Related Issue

Closes #PWA-3049

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Mar 14, 2023

Fails
🚫 A version label is required. A maintainer must add one.
Messages
📖

Associated JIRA tickets: PWA-3049.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against d1d6033

@glo82145
Copy link
Collaborator Author

run cypress

@pwa-test-bot
Copy link

pwa-test-bot bot commented Mar 23, 2023

Successfully started codebuild job for cypress

@glo82145
Copy link
Collaborator Author

run lighthouse-desktop

@pwa-test-bot
Copy link

pwa-test-bot bot commented Mar 23, 2023

Successfully started codebuild job for lighthouse-desktop

@glo82145
Copy link
Collaborator Author

run lighthouse-mobile

@pwa-test-bot
Copy link

pwa-test-bot bot commented Mar 23, 2023

Successfully started codebuild job for lighthouse-mobile

@pwa-studio-bot
Copy link
Collaborator

Fails
🚫

node failed.

🚫

Cypress tests in the following files did not pass 😔. All tests must pass before this PR can be merged

  • user should be able to add and remove promotions from cart:
    • AssertionError: Timed out retrying after 30000ms: Expected not to exist in the DOM, but it was continuously found.
  • user should be able to update their address book:
    • CypressError: Timed out retrying after 60000ms: `cy.wait()` timed out waiting `60000ms` for the 1st request to the route: `gqlSignInAfterCreateMutation`. No request ever occurred.

      https://on.cypress.io/wait

Log

ERROR ON TASK: cypressTests


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

Generated by 🚫 dangerJS against a5c090a

@glo82145
Copy link
Collaborator Author

run pr-test

@pwa-test-bot
Copy link

pwa-test-bot bot commented Mar 23, 2023

Successfully started codebuild job for pr-test

@glo82145
Copy link
Collaborator Author

run lighthouse-desktop

@pwa-test-bot
Copy link

pwa-test-bot bot commented Mar 23, 2023

Successfully started codebuild job for lighthouse-desktop

@glo82145
Copy link
Collaborator Author

run lighthouse-mobile

@pwa-test-bot
Copy link

pwa-test-bot bot commented Mar 23, 2023

Successfully started codebuild job for lighthouse-mobile

@glo82145 glo82145 merged commit f545bf6 into magento:develop Mar 23, 2023
@RaghavendraTirumalasetti RaghavendraTirumalasetti added the version: Patch This changeset includes backwards compatible bug fixes. label Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:pagebuilder Progress: done version: Patch This changeset includes backwards compatible bug fixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants