You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now also add gift card 02Y0LCHUNDRZ and check graphql response.
Issue - As per 2.4.5, Prices > Discounts array should not contain gift cards. But on 2.4.6, Prices > Discounts array contains gift cards as well. First check with PO whats the expected behavior.
DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖
Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
m2-community-project
bot
added
Progress: review
and removed
Progress: ready for review
labels
RaghavendraTirumalasetti
added
the
version: Minor
… Cards in 2.4.6
Description
URL - https://pr-4030.pwa-venia.com/
Steps -
Issue - As per 2.4.5, Prices > Discounts array should not contain gift cards. But on 2.4.6, Prices > Discounts array contains gift cards as well. First check with PO whats the expected behavior.
NOTE. - We have cypress test which is failing
venia-integration-tests/src/tests/e2eTests/cart/userRemoveCartPromotions.spec.js
Related Issue
Closes #https://jira.corp.adobe.com/browse/PWA-3071
Acceptance
Verification Stakeholders
Specification
Verification Steps
Test scenario(s) for direct fix/feature
Test scenario(s) for any existing impacted features/areas
Test scenario(s) for any Magento Backend Supported Configurations
Is Browser/Device testing needed?
Any ad-hoc/edge case scenarios that need to be considered?
Screenshots / Screen Captures (if appropriate)
Breaking Changes (if any)
Checklist