Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Dev Container config #4040

Merged
merged 3 commits into from
May 16, 2023
Merged

Conversation

rafaelstz
Copy link
Member

@rafaelstz rafaelstz commented Feb 21, 2023

Description

I'm adding Dev Container configurations to improve the developer experience.
The test is very straightforward, we just need to open it on VSCode locally and it will detect the Dev Container files and suggest opening it via Dev Container.

Capture d’écran, le 2023-02-20 à 19 55 28

Capture d’écran, le 2023-02-20 à 19 56 03

Or we can create a Github CodeSpace environment and the environment will be prepared to start coding.

Capture d'écran 20 02 2023 à 19 48 03 p m

Resolved issues:

  1. resolves [Issue] Adding Dev Container config #4041: Adding Dev Container config

@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Feb 21, 2023

Fails
🚫

No linked issue found. Please link a relevant open issue by adding the text "closes #<issue_number>" or "closes JIRA-<issue_number>" in your PR.

🚫 Missing "Verification Steps" section. Please add it back, with detail.
Messages
📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

If your PR is missing information, check against the original template here. At a minimum you must have the section headers from the template and provide some information in each section.

Generated by 🚫 dangerJS against 67f683b

@anthoula
Copy link
Contributor

@magento create issue from PR

@glo82145 glo82145 added the version: Minor This changeset includes functionality added in a backwards compatible manner. label May 16, 2023
@glo82145
Copy link
Collaborator

run lighthouse-desktop

@pwa-test-bot
Copy link

pwa-test-bot bot commented May 16, 2023

Successfully started codebuild job for lighthouse-desktop

@glo82145
Copy link
Collaborator

run lighthouse-mobile

@pwa-test-bot
Copy link

pwa-test-bot bot commented May 16, 2023

Successfully started codebuild job for lighthouse-mobile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Partner: Le Site partners-contribution Progress: done version: Minor This changeset includes functionality added in a backwards compatible manner.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Issue] Adding Dev Container config
5 participants