Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AC-6679::The button is not usable by keyboard #3980

Merged
merged 6 commits into from
Nov 16, 2022
Merged

AC-6679::The button is not usable by keyboard #3980

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
53247af
AC-6679::The button is not usable by keyboard
glo82145 Oct 17, 2022
391bb37
Merge branch 'develop' into AC-6679
glo82145 Oct 17, 2022
68c4786
Merge branch 'develop' into AC-6679
jcalcaben Nov 14, 2022
8c96ff2
Merge branch 'develop' into AC-6679
jcalcaben Nov 15, 2022
43c4d59
Merge branch 'develop' into AC-6679
dpatil-magento Nov 15, 2022
b914c2c
revert test change
dpatil-magento Nov 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion ...ges/peregrine/lib/hooks/useCustomerWishlistSkus/__tests__/useCustomerWishlistSkus.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ test('pre-caches wishlist items', async () => {
Object {
"customerWishlistProducts": Array [
"Dress",
"Shirt",
],
}
`);
Expand Down
1 change: 1 addition & 0 deletions ...es/peregrine/lib/talons/CheckoutPage/__tests__/__snapshots__/useCheckoutPage.spec.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ Object {
"error": undefined,
"guestSignInUsername": "",
"handlePlaceOrder": [Function],
"handlePlaceOrderEnterKeyPress": [Function],
"handleReviewOrder": [Function],
"hasError": false,
"isCartEmpty": true,
Expand Down
10 changes: 10 additions & 0 deletions packages/peregrine/lib/talons/CheckoutPage/useCheckoutPage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ export const CHECKOUT_STEP = {
* customer: Object,
* error: ApolloError,
* handlePlaceOrder: Function,
* handlePlaceOrderEnterKeyPress: Function,
* hasError: Boolean,
* isCartEmpty: Boolean,
* isGuestCheckout: Boolean,
Expand Down Expand Up @@ -241,6 +242,14 @@ export const useCheckoutPage = (props = {}) => {
setIsPlacingOrder(true);
}, [cartId, getOrderDetails]);

const handlePlaceOrderEnterKeyPress = useCallback(() => {
event => {
if (event.key === 'Enter') {
jcalcaben marked this conversation as resolved.
Show resolved Hide resolved
handlePlaceOrder();
}
};
}, [handlePlaceOrder]);

const [, { dispatch }] = useEventingContext();

// Go back to checkout if shopper logs in
Expand Down Expand Up @@ -377,6 +386,7 @@ export const useCheckoutPage = (props = {}) => {
error: checkoutError,
guestSignInUsername,
handlePlaceOrder,
handlePlaceOrderEnterKeyPress,
hasError: !!checkoutError,
isCartEmpty: !(checkoutData && checkoutData?.cart?.total_quantity),
isGuestCheckout: !isSignedIn,
Expand Down
2 changes: 2 additions & 0 deletions packages/venia-ui/lib/components/CheckoutPage/checkoutPage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ const CheckoutPage = props => {
error,
guestSignInUsername,
handlePlaceOrder,
handlePlaceOrderEnterKeyPress,
hasError,
isCartEmpty,
isGuestCheckout,
Expand Down Expand Up @@ -270,6 +271,7 @@ const CheckoutPage = props => {
checkoutStep === CHECKOUT_STEP.REVIEW ? (
<Button
onClick={handlePlaceOrder}
onKeyDown={handlePlaceOrderEnterKeyPress}
priority="high"
className={classes.place_order_button}
data-cy="CheckoutPage-placeOrderButton"
Expand Down