-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PWA-2985: [bug]: Payment method always reverts to "Check / Money orde… #3969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r” when there is an error with the transaction - Set selected payment method mutation upon onChange event - Set initialSelectedMethod to selected_payment_method data - Update test coverage & snapshots
anthoula
added
the
version: Minor
This changeset includes functionality added in a backwards compatible manner.
label
Sep 30, 2022
|
fnhipster
previously approved these changes
Sep 30, 2022
m2-community-project
bot
added
Progress: approved
and removed
Progress: ready for review
labels
Sep 30, 2022
run cypress |
Successfully started codebuild job for |
@anthoula Please check following observations -
|
…r” when there is an error with the transaction - Set default/initial payment method - Add tests - Update padding
…r” when there is an error with the transaction - Revert suggested snap update
run cypress |
Successfully started codebuild job for |
dpatil-magento
approved these changes
Oct 3, 2022
QA Approved |
bdenham
changed the title
PWA-2985: [bug]: Payment method always reverts to “Check / Money orde…
PWA-2985: [bug]: Payment method always reverts to "Check / Money orde…
Apr 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pkg:peregrine
pkg:venia-ui
Progress: done
version: Minor
This changeset includes functionality added in a backwards compatible manner.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…r" when there is an error with the transaction
Description
Related Issue
Closes #PWA-2985.
Acceptance
Verification Stakeholders
Specification
Verification Steps
Test scenario(s) for direct fix/feature
Test scenario(s) for any existing impacted features/areas
Test scenario(s) for any Magento Backend Supported Configurations
Is Browser/Device testing needed?
Any ad-hoc/edge case scenarios that need to be considered?
Screenshots / Screen Captures (if appropriate)
Breaking Changes (if any)
Checklist