Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AC-2498-Images lacking meaningful alternative text. (Account - Order … #3944

Merged
merged 7 commits into from
Nov 16, 2022

Conversation

glo82145
Copy link
Collaborator

@glo82145 glo82145 commented Aug 26, 2022

…History)

Description

Reproduction Steps
Sign In > select "Order History" from account dropdown - [NODE][body>div:nth-of-type(1)>:nth-child(1)>:nth-child(3)]

  1. With JAWS operating, use the down arrow key to read through a collapsed preview of an order with multiple products.

Actual Behavior
In the Order History list, when an order accordion is closed, the product images do not provide meaningful alternative text - each image listed has alt text of "Main". The information conveyed by these images - i.e. a quick view of products included in the order - is not provided to screen reader users.

Note that there are two elements for each product image (for eager and lazy loading); although the eager image is visually hidden, it is still available to assistive technology. As a result, the same alt text for each product is announced twice.

Expected Behavior
Images that convey information must provide descriptive textual alternatives. In this case, the alt text for each image should be brief but identifying image about the product, likely the product name.

Ensure that content intended to be hidden from all users, such as the eager image once the lazy image loads, is also hidden from assistive technology.

Related Issue

Closes #AC-2498.

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

Resolved issues:

  1. resolves [Issue] AC-2498-Images lacking meaningful alternative text. (Account - Order … #3946: AC-2498-Images lacking meaningful alternative text. (Account - Order …

@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Aug 26, 2022

Messages
📖

Associated JIRA tickets: AC-2498.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against 8531cb4

@anthoula
Copy link
Contributor

@magento create issue from PR

@anthoula anthoula added the version: Patch This changeset includes backwards compatible bug fixes. label Nov 11, 2022
Copy link
Contributor

@anthoula anthoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @glo82145 - Would you take a look and resolve the failing unit test please? useCustomerWishlistSkus.spec.js

@dpatil-magento
Copy link
Contributor

run cypress

@pwa-test-bot
Copy link

pwa-test-bot bot commented Nov 16, 2022

Successfully started codebuild job for cypress

@pwa-studio-bot
Copy link
Collaborator

Fails
🚫

node failed.

🚫

Cypress tests in the following files did not pass 😔. All tests must pass before this PR can be merged

  • user should be able to update their address book:
    • CypressError: Timed out retrying after 60000ms: `cy.wait()` timed out waiting `60000ms` for the 1st request to the route: `gqlSignInAfterCreateMutation`. No request ever occurred.

      https://on.cypress.io/wait

Log

ERROR ON TASK: cypressTests


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

Generated by 🚫 dangerJS against 8531cb4

@dpatil-magento
Copy link
Contributor

QA Approved

@dpatil-magento dpatil-magento merged commit 8dc9b8d into magento:develop Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:peregrine pkg:venia-ui Progress: done version: Patch This changeset includes backwards compatible bug fixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Issue] AC-2498-Images lacking meaningful alternative text. (Account - Order …
4 participants