Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes on this PR: AC-2480::Flyout panels do not trap focus while open #3805 #3942

Merged
merged 5 commits into from
Sep 30, 2022

Conversation

sanganinamrata
Copy link
Member

@sanganinamrata sanganinamrata commented Aug 25, 2022

Description

Fixing #3805 PR based on my comment #3805 (comment)

closes #3943

Closes https://jira.corp.adobe.com/browse/ACSFT-48

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

sanganinamrata and others added 2 commits August 25, 2022 13:48
… Fixed console error with attribute name in lowercase.
@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Aug 25, 2022

Messages
📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against acdde28

@anthoula anthoula added version: Minor This changeset includes functionality added in a backwards compatible manner. version: Patch This changeset includes backwards compatible bug fixes. and removed version: Minor This changeset includes functionality added in a backwards compatible manner. labels Sep 15, 2022
@dpatil-magento
Copy link
Contributor

@sanganinamrata Can following error also be taken care part of this PR?

Warning: Failed prop type: Invalid prop `tabIndex` of type `string` supplied to `Tree`, expected `function`.

@anthoula
Copy link
Contributor

Hey @sanganinamrata , Thanks for your contribution! We are looking to include this in our upcoming release.

Can following error also be taken care part of this PR?

Warning:` Failed prop type: Invalid prop `tabIndex` of type `string` supplied to `Tree`, expected `function`.

@dpatil-magento
Copy link
Contributor

run cypress

@pwa-test-bot
Copy link

pwa-test-bot bot commented Sep 30, 2022

Successfully started codebuild job for cypress

@dpatil-magento dpatil-magento merged commit 78d7452 into magento:develop Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:venia-ui Progress: done version: Patch This changeset includes backwards compatible bug fixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: AC-2481::Flyout panels do not trap focus while open
4 participants