Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logo misses required alt property for image #3936

Merged
merged 2 commits into from
Sep 14, 2022

Conversation

jissereitsma
Copy link
Contributor

@jissereitsma jissereitsma commented Aug 20, 2022

In my installation, the Image component requires the alt property, but the Logo component does not render one.

Resolved issues:

  1. resolves [Issue] Logo misses required alt property for image #3937: Logo misses required alt property for image

In my installation, the Image component requires the `alt` property, but the `Logo` component does not render one.
@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Aug 20, 2022

Fails
🚫

No linked issue found. Please link a relevant open issue by adding the text "closes #<issue_number>" or "closes JIRA-<issue_number>" in your PR.

🚫 Missing "Verification Steps" section. Please add it back, with detail.
🚫 Missing "Description" section. Please add it back, with detail.
Messages
📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

If your PR is missing information, check against the original template here. At a minimum you must have the section headers from the template and provide some information in each section.

Generated by 🚫 dangerJS against 289bf5f

@anthoula
Copy link
Contributor

@magento create issue from PR

@anthoula anthoula added the version: Patch This changeset includes backwards compatible bug fixes. label Sep 13, 2022
@dpatil-magento
Copy link
Contributor

run cypress

@pwa-test-bot
Copy link

pwa-test-bot bot commented Sep 14, 2022

Successfully started codebuild job for cypress

@dpatil-magento
Copy link
Contributor

run lighthouse-desktop

@pwa-test-bot
Copy link

pwa-test-bot bot commented Sep 14, 2022

Successfully started codebuild job for lighthouse-desktop

@dpatil-magento
Copy link
Contributor

run lighthouse-mobile

@pwa-test-bot
Copy link

pwa-test-bot bot commented Sep 14, 2022

Successfully started codebuild job for lighthouse-mobile

@dpatil-magento dpatil-magento merged commit bf40b3b into magento:develop Sep 14, 2022
@jissereitsma jissereitsma deleted the patch-1 branch September 15, 2022 06:28
@jissereitsma
Copy link
Contributor Author

@dpatil-magento I've been sloppy in replies, but thanks for pursuing this issue and merging! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:venia-ui Progress: done version: Patch This changeset includes backwards compatible bug fixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Issue] Logo misses required alt property for image
4 participants