AC-2479::Visual text label does not match accessible name. (Global He… #3932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
@magento create issue from PR |
|
Hi @glo82145 - This looks good, thank you. Would you look at & resolve the conflicting files please? |
anthoula
added
the
version: Patch
anthoula
approved these changes
Nov 11, 2022
m2-community-project
bot
added
Progress: approved
and removed
Progress: ready for review
labels
|
run cypress |
|
Successfully started codebuild job for |
|
run cypress @snapshot |
|
Successfully started codebuild job for |
|
QA Approved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ader)
Description
Reproduction Steps
[NODE][body>div:nth-of-type(1)>:nth-child(1)>:nth-child(2)]
Actual Behavior
The following buttons have visible text that does not match the button's accessible name:
Header - Visible label "Sign In"; Accessible name "Toggle My Account Menu"
Navigation Menu - Visible label "Sign In"; Accessible name "Account Sign In" (Note - this instance is advisory only since the accessible name contains the visible label text; however it is preferable for the accessible name to start with the visible text.)
When the accessible name of a control does not include the visible text label, users of speech input software may be unable to access the control directly.
Expected Behavior
Ensure the visible text label of a control is included in the control's accessible name. It is highly recommended that the accessible name start with the visible label text.
Related Issue
Closes #https://jira.corp.adobe.com/browse/AC-2479
Acceptance
Verification Stakeholders
Specification
Verification Steps
Test scenario(s) for direct fix/feature
Test scenario(s) for any existing impacted features/areas
Test scenario(s) for any Magento Backend Supported Configurations
Is Browser/Device testing needed?
Any ad-hoc/edge case scenarios that need to be considered?
Screenshots / Screen Captures (if appropriate)
Breaking Changes (if any)
Checklist
Resolved issues: