Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PWA-2482: Update product detail page for out of stock variations #3903

Merged
merged 24 commits into from
Aug 19, 2022
Merged

PWA-2482: Update product detail page for out of stock variations #3903

merged 24 commits into from
Aug 19, 2022

Conversation

cctina516
Copy link
Contributor

Description

Display out of stock variations for configurable products on product detail page.

Preconditions

  • Display Out of Stock Products = yes in Admin>Store >Configuration>Catalog>Inventory>Stock Options
  • Configurable Product 1 created with all variations Out of Stock
  • Configurable Product 2 created with one of the variations is Out of Stock
  • Customer is on the storefront PDP

Related Issue

https://jira.corp.magento.com/browse/PWA-2482

Acceptance

Verification Stakeholders

Specification

Verification Steps

  1. Display Out of Stock Products = yes in Admin>Store >Configuration>Catalog>Inventory>Stock Options
  2. Create new configurable products for testing
  3. Set Configurable Product 1 created with all variations Out of Stock
  4. Set Configurable Product 2 created with one/some of the variations Out of Stock

Test scenario(s) for direct fix/feature

  1. Customer navigates to the Product 1 PDP and sees swatches related to the out of stock variations disabled and no CTA to add product to cart present
  2. Customer navigate to the product 2 PDP and sees swatches active. User selects a swatch and sees related swatches updated to reflect the stock status of the variation - combination that is out of stock becomes disabled
  3. User can't select a disable swatch

Test scenario(s) for any existing impacted features/areas

  1. Customers are not able to add out of stock items to the cart
  2. Customers are able to add available items to the cart

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Breaking Changes (if any)

Checklist

jcalcaben
jcalcaben reviewed Jul 18, 2022
View reviewed changes
Copy link
Contributor

@jcalcaben jcalcaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some initial review comments

packages/peregrine/lib/talons/ProductFullDetail/useProductFullDetail.js Outdated Show resolved Hide resolved
packages/peregrine/lib/util/getOutOfStockIndexes.js Outdated Show resolved Hide resolved
packages/peregrine/lib/talons/ProductFullDetail/useProductFullDetail.js Outdated Show resolved Hide resolved
packages/peregrine/lib/talons/ProductFullDetail/useProductFullDetail.js Outdated Show resolved Hide resolved
packages/peregrine/lib/talons/ProductFullDetail/useProductFullDetail.js Show resolved Hide resolved
packages/venia-ui/lib/components/ProductOptions/swatchList.js Outdated Show resolved Hide resolved
packages/venia-ui/lib/components/ProductOptions/tileList.js Outdated Show resolved Hide resolved
@cctina516
Update product detail page files based on review comments and add con…
d171ca4 
…ditions for not display out of stock products
@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Jul 22, 2022 •
edited
Loading

Messages
📖

Associated JIRA tickets: PWA-2482.
📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against 0ee0c9b

jcalcaben
jcalcaben requested changes Jul 26, 2022
View reviewed changes
Copy link
Contributor

@jcalcaben jcalcaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some additional feedback

packages/peregrine/lib/talons/AddToCartDialog/useAddToCartDialog.js Outdated Show resolved Hide resolved
packages/peregrine/lib/talons/CartPage/ProductListing/EditModal/useProductForm.js Outdated Show resolved Hide resolved
packages/peregrine/lib/util/createProductVariants.js Show resolved Hide resolved
packages/venia-ui/lib/components/ProductFullDetail/productFullDetail.js Outdated Show resolved Hide resolved
packages/peregrine/lib/util/findAllMatchingVariants.js Outdated Show resolved Hide resolved
packages/peregrine/lib/util/findAllMatchingVariants.js Outdated Show resolved Hide resolved
jcalcaben
jcalcaben previously approved these changes Aug 16, 2022
View reviewed changes
@dpatil-magento dpatil-magento marked this pull request as ready for review August 17, 2022 15:08
@dpatil-magento
Copy link
Contributor

run cypress

@pwa-test-bot
Copy link

pwa-test-bot bot commented Aug 17, 2022

Successfully started codebuild job for cypress

@dpatil-magento
Copy link
Contributor

run cypress

@pwa-test-bot
Copy link

pwa-test-bot bot commented Aug 18, 2022

Successfully started codebuild job for cypress

@dpatil-magento
Copy link
Contributor

run lighthouse-desktop

@pwa-test-bot
Copy link

pwa-test-bot bot commented Aug 19, 2022

Successfully started codebuild job for lighthouse-desktop

@dpatil-magento
Copy link
Contributor

run lighthouse-mobile

@pwa-test-bot
Copy link

pwa-test-bot bot commented Aug 19, 2022

Successfully started codebuild job for lighthouse-mobile

@dpatil-magento dpatil-magento merged commit ccd9558 into develop Aug 19, 2022
@dpatil-magento dpatil-magento deleted the ctina/PWA-2482 branch August 19, 2022 15:50
@anthoula anthoula added version: Minor This changeset includes functionality added in a backwards compatible manner. and removed version: Major This changeset includes incompatible API changes and its release necessitates a Major version bump. labels Aug 23, 2022
@dpatil-magento dpatil-magento mentioned this pull request Oct 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpatil-magento dpatil-magento dpatil-magento approved these changes

@jcalcaben jcalcaben jcalcaben left review comments

Assignees

@jcalcaben jcalcaben

@dpatil-magento dpatil-magento

Labels
pkg:extensions pkg:peregrine pkg:pwa-theme-venia pkg:venia-ui Progress: done version: Minor This changeset includes functionality added in a backwards compatible manner.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cctina516 @pwa-studio-bot @dpatil-magento @jcalcaben @anthoula