Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AC-3522::Product search result with items count is not being read by screen reader #3891

Merged
merged 4 commits into from
Aug 29, 2022

Conversation

glo82145
Copy link
Collaborator

@glo82145 glo82145 commented Jun 22, 2022

Description

product search result with items count is not being read by screen reader

Pre Conditions:

Have Venia setup working with Magento 2.4.5-alpha2 in the local.
Have sample data available in the instance
Have Google chrome screen reader extension enabled and working.
Steps to reproduce:

Keeping extension enabled, open the venia front end in the chrome browser.
Tab the focus to search button in the home page.
Press return key from the keyboard and input with the text that results with items found. (ex: carina)
Expected: Screen reader should announce the total items found in the searched result.

Actual: Randomly announcing the text from left side filters options sometimes or sort items dropdown, as such.

Related Issue

Closes https://jira.corp.magento.com/projects/AC/issues/AC-3522

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

Resolved issues:

  1. resolves [Issue] AC-3522::Product search result with items count is not being read by screen reader #3920: AC-3522::Product search result with items count is not being read by screen reader

@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Jun 22, 2022

Fails
🚫 A version label is required. A maintainer must add one.
Messages
📖

Associated JIRA tickets: AC-3522.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against 6671774

@dpatil-magento
Copy link
Contributor

run pr-deploy

@pwa-test-bot
Copy link

pwa-test-bot bot commented Jul 1, 2022

Successfully started codebuild job for pr-deploy

@anthoula
Copy link
Contributor

@adobe create issue from PR

@anthoula
Copy link
Contributor

@magento create issue from PR

jcalcaben
jcalcaben previously approved these changes Aug 24, 2022
@dpatil-magento
Copy link
Contributor

run cypress

@pwa-test-bot
Copy link

pwa-test-bot bot commented Aug 26, 2022

Successfully started codebuild job for cypress

@dpatil-magento
Copy link
Contributor

run lighthouse-desktop

@pwa-test-bot
Copy link

pwa-test-bot bot commented Aug 26, 2022

Successfully started codebuild job for lighthouse-desktop

@dpatil-magento
Copy link
Contributor

run lighthouse-mobile

@pwa-test-bot
Copy link

pwa-test-bot bot commented Aug 26, 2022

Successfully started codebuild job for lighthouse-mobile

@dpatil-magento dpatil-magento added the version: Patch This changeset includes backwards compatible bug fixes. label Aug 29, 2022
@dpatil-magento dpatil-magento merged commit 9cd21e6 into magento:develop Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:venia-ui Progress: done version: Patch This changeset includes backwards compatible bug fixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Issue] AC-3522::Product search result with items count is not being read by screen reader
5 participants