-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jconabree/issue 3873 talon exports #3874
Jconabree/issue 3873 talon exports #3874
Conversation
|
run cypress |
Successfully started codebuild job for |
run lighthouse-desktop |
Successfully started codebuild job for |
run lighthouse-mobile |
Successfully started codebuild job for |
QA Approved, would be merged in next |
run cypress |
Successfully started codebuild job for |
LogERROR ON TASK: cypressTests
|
Cypress failures are not related. |
…rk correctly
Description
Certain hooks and talons were exporting default instead of a named export. Named exports are required for exposing talons and hooks for wrapping
Note: It would be nice to have a test that checks the export is available so this doesn't occur in the future. Or possibly leverage eslint-import-plugin's
no-default-export
ruleRelated Issue
Closes #3873
Acceptance
Verification Stakeholders
Specification
Verification Steps
Test scenario(s) for direct fix/feature
Test scenario(s) for any existing impacted features/areas
Is Browser/Device testing needed?
No
Breaking Changes (if any)
Export name changes for affected talons and hooks
Checklist
[ ] I have added translations for new strings, if necessary.[ ] I have updated the documentation accordingly, if necessary.