Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename identities to be appropriate #2478

Merged
merged 2 commits into from
Jun 12, 2020
Merged

Rename identities to be appropriate #2478

merged 2 commits into from
Jun 12, 2020

Conversation

jimbo
Copy link
Contributor

@jimbo jimbo commented Jun 9, 2020

Description

Certain terms in programming vernacular have connotations or implications that make them less than appropriate. Where we can replace them with alternatives, we should.

See the corresponding PR in core.

Related Issue

Closes PWA-652.

Acceptance

@jcalcaben
@awilcoxa

Verification Stakeholders

@dpatil-magento

Specification

Verification Steps

No net change.

Screenshots / Screen Captures (if appropriate)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have updated the documentation accordingly, if necessary.

@jimbo jimbo added the version: Patch This changeset includes backwards compatible bug fixes. label Jun 9, 2020
@PWAStudioBot
Copy link
Contributor

PWAStudioBot commented Jun 9, 2020

Messages
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).
📖

Associated JIRA tickets: PWA-652.

Generated by 🚫 dangerJS against 112ebca

@devops-pwa-codebuild
Copy link
Collaborator

devops-pwa-codebuild commented Jun 9, 2020

Performance Test Results

The following fails have been reported by WebpageTest. These numbers indicates a possible performance issue with the PR which requires further manual testing to validate.

https://pr-2478.pwa-venia.com : LH Performance Expected 0.85 Actual 0.57, LH Best Practices Expected 1 Actual 0.92
https://pr-2478.pwa-venia.com/venia-tops.html : LH Performance Expected 0.75 Actual 0.36, LH Best Practices Expected 1 Actual 0.92
https://pr-2478.pwa-venia.com/valeria-two-layer-tank.html : LH Performance Expected 0.8 Actual 0.48, LH Accessibility Expected 0.9 Actual 0.89, LH Best Practices Expected 1 Actual 0.92

@dpatil-magento
Copy link
Contributor

Accidentally hit close instead of Merge previously, re-opened and merged.

@dpatil-magento dpatil-magento deleted the PWA-652 branch September 14, 2020 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:peregrine version: Patch This changeset includes backwards compatible bug fixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants