-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Strict SW catalog image checking. #2392
Strict SW catalog image checking. #2392
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, and I've confirmed on a local that it does resolve the bug. I assume a test will come later, but nice work 👍
I forgot to push the test. Done 👍 |
Performance Test Results The following fails have been reported by WebpageTest. These numbers indicates a possible performance issue with the PR which requires further manual testing to validate. https://pr-2392.pwa-venia.com/venia-tops.html : LH Performance Expected 0.75 Actual 0.71 |
packages/venia-concept/src/ServiceWorker/Utilities/__tests__/imageCacheHandler.spec.js
Outdated
Show resolved
Hide resolved
…mageCacheHandler.spec.js Co-authored-by: Tommy Wiebell <[email protected]>
Description
@Jordaneisenburger has explained the issue at hand very well in the related issue.
It is a fairly simple fix. All we have to do is to compare the file names instead of checking for text includes.
I could not replicate the issue at hand because could not find URLs like mentioned in the issue. But, I have tested the SW cache handling and it works fine.
@Jordaneisenburger it would be great if you can validate the issue against this PR.
Related Issue
Closes #2332
Verification Stakeholders
@jimbo
@Jordaneisenburger
Verification Steps
(I was able to reproduce the issue so updated steps)
Checklist
None