[chore]: Order Summary fast follow #2278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sirugh <[email protected]>
Signed-off-by: sirugh <[email protected]>
Signed-off-by: sirugh <[email protected]>
Signed-off-by: sirugh <[email protected]>
Signed-off-by: sirugh <[email protected]>
sirugh
commented
Mar 24, 2020
| @@ -47,9 +46,6 @@ const CheckoutPage = props => { | |||
|
|
|||
| const classes = mergeClasses(defaultClasses, propClasses); | |||
|
|
|||
| const windowSize = useWindowSize(); | |||
| const isMobile = windowSize.innerWidth <= 960; | |||
There was a problem hiding this comment.
Spoke with @jimbo we may actually wnat to use window size now considering upcoming UX changes.
There was a problem hiding this comment.
Reverted this to use the hook again :)
supernova-at
previously approved these changes
Mar 25, 2020
Signed-off-by: sirugh <[email protected]>
supernova-at
approved these changes
Mar 25, 2020
jimbo
approved these changes
Mar 25, 2020
|
CI builds didn't run because of https://jira.corp.magento.com/browse/PWA-467. Ran MFTF test and verification on local stage:venia. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@jimbo requested some fast follow items from #2271. Addressing them here.
Related Issue
Closes PWA-466.
Acceptance
Verification Stakeholders
@jimbo
Specification
Verification Steps
/cartmake sure proceed to checkout button works./checkoutmake sure summary always displayed on desktop/checkoutmake sure summary hidden unless in review step on mobile.6.Make sure proceed to checkout button appears on cart but not checkout.
Screenshots / Screen Captures (if appropriate)
Checklist