ISSUE-2223: Fixed the bug with breadcrumbs on PDP with a product without categories #2224
Conversation
|
There was a problem hiding this comment.
Thanks for opening this PR! This definitely solves the case for when there are no categories for a product, especially since it was previously just throwing an error.
Please make the minor change to the conditional and add a comment above it as suggested.
Cheers!
| @@ -97,6 +97,9 @@ const getMediaGalleryEntries = (product, optionCodes, optionSelections) => { | |||
| // product has multiple related categories. This function filters and selects | |||
| // one category id for that purpose. | |||
| const getBreadcrumbCategoryId = categories => { | |||
| if (!!categories.length === false) { | |||
There was a problem hiding this comment.
I'm guessing categories is an empty array when we get here and there is no category assigned to a product. In that case, let's just use a simple check against truthyness of categories and check whether there are any values in categories array, if it exists:
// Exit if there are no categories for this product.
if (!categories || !categories.length) {
return;
}
There was a problem hiding this comment.
@andrewbess Thanks for contributing! Looks like a simple fix. 👍
@sirugh Agreed, good suggestion.
There was a problem hiding this comment.
Hello @sirugh
Thank you for review.
I have fixed it.
Please check.
| @@ -97,6 +97,9 @@ const getMediaGalleryEntries = (product, optionCodes, optionSelections) => { | |||
| // product has multiple related categories. This function filters and selects | |||
| // one category id for that purpose. | |||
| const getBreadcrumbCategoryId = categories => { | |||
| if (!!categories.length === false) { | |||
There was a problem hiding this comment.
@andrewbess Thanks for contributing! Looks like a simple fix. 👍
@sirugh Agreed, good suggestion.
|
Looks good.
|
Description
This PR fixes the bug with breadcrumbs on PDP when a product isn't assigned anything category
Related Issue
Closes #2223.
Acceptance
Verification Stakeholders
Specification
Verification Steps
Screenshots / Screen Captures (if appropriate)