Applied Gift Cards show current balance #2156
Conversation
supernova-at
changed the title
| } | ||
|
|
||
| .balance { | ||
| font-size: 0.875rem; |
There was a problem hiding this comment.
This is computed based on the Venia Styleguide:
Since we don't have CSS Properties (variables) for font sizes yet, 0.875rem = 14px.
|
| unit test card code | ||
| </span> | ||
| <span> | ||
| Balance: |
There was a problem hiding this comment.
There is no balance in these snaps, not even a zero. Expected?
There was a problem hiding this comment.
Expected because the value is rendered via the Price component, which gets mocked here to an empty <div /> (see next line).
There was a problem hiding this comment.
Aside from the snaps (maybe) being off, I approve!
@schensley will want to approve as well, methinks.
sirugh
added
the
version: Patch
|
@supernova-at the implementation looks very good. One fussy thing, the balance could use a little bit more separation for the card number once it has been applied. |
| <span> | ||
| 00 | ||
| </span> | ||
| </span> |
There was a problem hiding this comment.
@sirugh I think this Price component doesn't get mocked because we requireActual Peregrine in this .spec.js. Apparently that will ignore mocks in __mocks__ 🤷♂
@schensley , resolved by af7baf6. |
Description
This PR adds current applied gift card balances to the UI to improve the UX.
The balance font size is slightly smaller than the code, so I consulted the Venia Styleguide for its value.
Related Issue
Closes PWA-364.
Acceptance
Verification Stakeholders
Specification
Verification Steps
/cartpageScreenshots / Screen Captures (if appropriate)
Checklist