-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gift Cards #2124
Gift Cards #2124
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@supernova-at Great work. Looks much better to me. 👍
@supernova-at https://pr-2124.pwa-venia.com/cart running on EE but dont see Gift Cards accordion. Also when run on local with CE, dont see any of the accordion. |
Resolved in-person. New |
@supernova-at EE looks good but CE does not show any of the accordion (Shipping, Coupon, Gift options). Does this work for you? |
It does: Do you have items in your cart? That's the only thing I can think of that hides the entire accordion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for changing the query to lazy. Aside from the CE vs EE issue that @dpatil-magento is seeing this looks good to me.
Fixed the issue! Check out commit 24b7fb5. Verify:
Thanks @dpatil-magento @sirugh @tjwiebell ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noice.
Description
This PR adds Gift Card support to the new Cart page.
Known issues out of scope:
PriceAdjustments
accordion resets back to the original set of sections that are open (isOpen={true}
) after mutations occur.Related Issue
Closes JIRA-78.
Acceptance
Verification Stakeholders
@schensley
Specification
Verification Steps
Since Gift Cards is an enterprise edition feature, first set your
MAGENTO_BACKEND_EDITION
toEE
.yarn watch:all
/cart
page02Y0LCHUNDRZ
.no_work
.02Y0LCHUNDRZ
.no_work
.Set your
MAGENTO_BACKEND_EDITION
back toCE
(CE
is also the default), and observe that the Cart page doesn't even show a Gift Card section in the Accordion.Screenshots / Screen Captures (if appropriate)
Checklist