-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature]: Cart Coupons #2108
[feature]: Cart Coupons #2108
Conversation
packages/venia-ui/lib/components/CartPage/PriceAdjustments/CouponCode/couponCode.js
Outdated
Show resolved
Hide resolved
|
packages/venia-ui/lib/components/CartPage/PriceAdjustments/CouponCode/couponCode.css
Outdated
Show resolved
Hide resolved
packages/venia-ui/lib/components/CartPage/PriceAdjustments/CouponCode/couponCode.css
Outdated
Show resolved
Hide resolved
@dpatil-magento do you have a coupon enabled on the PR deployment that @schensley can use to test out the UI? |
@sirugh I will create some and pass it to you all. |
01ba41b
to
16d6a96
Compare
@sirugh UI looks good.
Once done, this is approved by UX. Thnx |
Done!
I set the color of the text for the "remove link" to Thanks! |
Signed-off-by: Stephen Rugh <[email protected]>
…verfetch Signed-off-by: Stephen Rugh <[email protected]>
Signed-off-by: Stephen Rugh <[email protected]>
Signed-off-by: Stephen Rugh <[email protected]>
Signed-off-by: Stephen Rugh <[email protected]>
Signed-off-by: Stephen Rugh <[email protected]>
Signed-off-by: Stephen Rugh <[email protected]>
…e venia text variable for removal button. Signed-off-by: Stephen Rugh <[email protected]>
Signed-off-by: Stephen Rugh <[email protected]>
1a0c1d3
to
edd1cb3
Compare
Might have just found a bug -- when you add a coupon it doesn't show the remove view, at least not on the aws deployed version. I'll have to fix that and check why the tests didn't catch it. |
Signed-off-by: Stephen Rugh <[email protected]>
Did your latest commit fix this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. We'll eventually have an official "quiet" style for our buttons defined in the styleguide; this works for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved by UX.
Description
Adds the Coupon functionality to price adjustments.
Also updates price summary when a cart is added or removed.
Related Issue
Closes PWA-75.
Acceptance
Verification Stakeholders
Specification
Verification Steps
/cart
.pwa1423
if you are on the AWS deployed app.Additional Steps:
The
Field
component did not provide adequate spacing for a scenario where two fields are aligned next to each other in a grid and one field has a label (or error message and the other doesn't).In order to remedy this I added a
min-height
value to the field label style and made field components align their content to the start rather than be stretched by default.Please ensure that
Field
s across Venia still appear correctly and that there are no regressions.Screenshots / Screen Captures (if appropriate)
Checklist