Make pagination page buffer configurable #2032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sirugh
approved these changes
Dec 16, 2019
There was a problem hiding this comment.
This is a great example of the potential customization we can offer through the talons :) Good work @niklaswolf!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TileBuffer size is now configurable via props. It's completely backwards compatible because the new prop has the old value set as default.
Related Issue
Closes #1986 .
Acceptance
Verification Stakeholders
Specification
Verification Steps
Pagination talon works just like before but is now not limited to show a fixed amount of pages.