-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use updateItem mutations #2017
Use updateItem mutations #2017
Conversation
|
…e products. Also disables update button until an option has changed.
4657762
to
2bedea9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a question about preventing that double render on update.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good with loading indicator fix, nice work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even better now 👍
Description
Updates the
cartOptions
to use theupdateCartItems
mutation for simple products.As there is no update mutation for configurable products we just remove then add the new configuration in place of a singular update call.
I also added some logic to disable the
Update Cart
button until either the quantity or the options have been touched.Related Issue
Closes PWA-143.
Acceptance
Verification Stakeholders
Specification
Verification Steps
Simple product
Configurable product
Screenshots / Screen Captures (if appropriate)
Checklist