PWA-138: Re-factor getUserDetails to use GraphQL (useAwaitQuery Edition) #2004
Conversation
|
| const userDetails = await request('/rest/V1/customers/me', { | ||
| method: 'GET' | ||
| }); | ||
| const { data } = await fetch(); |
There was a problem hiding this comment.
This prevents other actions from calling each other as only components will have fetchers.
There was a problem hiding this comment.
Also we would want to ensure we handle the error appropriately. Does fetch throw an error or would we have to destructure error from the result?
There was a problem hiding this comment.
...you're absolutely right, and it would be nasty to have to pass query invokers for nested action calls, but it would more clearly define those action APIs.
fetch does throw on error, so this code should function as-is (though may need to destructure { error } in the catch.
tjwiebell
changed the title
tjwiebell
added
the
version: Major
tjwiebell
changed the title
QA
|
| method: 'GET' | ||
| const { data } = await fetchUserDetails({ | ||
| // until we can investigate some odd behavior with apollo-cache-persist | ||
| // not busting the cache on sign out, avoid caching user details. |
There was a problem hiding this comment.
@tjwiebell did we create a ticket for this?
Description
See PWA-138
Related Issue
Acceptance
Verification Stakeholders
Specification
Verification Steps
Screenshots / Screen Captures (if appropriate)
Checklist