Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added email validation to ForgotPasswordForm #1997

Merged
merged 9 commits into from
Dec 10, 2019
Merged

Added email validation to ForgotPasswordForm #1997

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
8564840
Added Email validation in forgot password form
gaurav-473 Nov 21, 2019
90be9a7
Merge branch 'develop' into develop-pr2
revanth0212 Nov 22, 2019
2228996
import combine
gaurav-473 Nov 25, 2019
4f44646
Merge branch 'develop' into develop-pr2
supernova-at Nov 26, 2019
99405f7
Fix import of combineValidators
sirugh Dec 6, 2019
dc62956
Merge branch 'develop' into develop-pr2
sirugh Dec 6, 2019
bbeb279
Merge branch 'develop' into develop-pr2
dpatil-magento Dec 8, 2019
4988364
Merge branch 'develop' into develop-pr2
revanth0212 Dec 9, 2019
b7188c7
Removing validateOnBlur.
revanth0212 Dec 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/venia-ui/lib/components/ForgotPassword/ForgotPasswordForm/forgotPasswordForm.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@ import Button from '../../Button';
import Field from '../../Field';
import TextInput from '../../TextInput';

import { isRequired } from '../../../util/formValidators';
import { isRequired, validateEmail } from '../../../util/formValidators';
import combine from '../../../util/combineValidators';

import { mergeClasses } from '../../../classify';
import defaultClasses from './forgotPasswordForm.css';
Expand All @@ -25,8 +26,7 @@ const ForgotPasswordForm = props => {
<TextInput
autoComplete="email"
field="email"
validate={isRequired}
validateOnBlur
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before @dpatil-magento merges maybe @revanth0212 can explain why we had to remove this. I feel like the validation should happen on blur and before submit, but it seems like it wasn't happening correctly.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue with validateOnBlur is that it only validates on blur. So once you enter a new valid email address and click on the submit button, the validation is not done yet and the click won't be registered because clicking button === losing focus for the email field but the validation result will only propagate in the next render. That is the reason why @dpatil-magento had to click twice.

validate={combine([isRequired, validateEmail])}
gaurav-473 marked this conversation as resolved.
Show resolved Hide resolved
/>
</Field>
<div className={classes.buttonContainer}>
Expand Down