[docs] Tutorial to create storefront component #1982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcalcaben
added
version: Patch
|
supernova-at
requested changes
Nov 20, 2019
|
|
||
| ## Congratulations | ||
|
|
||
| You just created a new storefront components using PWA Studio libraries and conventions. |
There was a problem hiding this comment.
🎉
May want to show that the click functionality / url_path works by including a screenshot after click?
m2-community-project
bot
added
Progress: review
and removed
Progress: changes requested
labels
jimbo
reviewed
Nov 21, 2019
There was a problem hiding this comment.
@jcalcaben This is great. Good overview of the process from start to finish.
supernova-at
previously approved these changes
Nov 22, 2019
tjwiebell
suggested changes
Nov 26, 2019
| + // categories is expected to be an object with a name and url_path string properties | ||
| + categories: arrayOf( | ||
| + shape:({ | ||
| + name: string, |
There was a problem hiding this comment.
Suggested change
| + name: string, | |
| + name: string.isRequired, |
m2-community-project
bot
added
Progress: review
and removed
Progress: changes requested
labels
tjwiebell
approved these changes
Dec 2, 2019
tjwiebell
deleted the
jimothy/pwa-124_create-storefront-component-tutorial
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a step-by-step tutorial for creating a TagList component for a PWA Studio storefront.
Related Issue
Closes PWA-124
Acceptance
@jimbo
Verification Stakeholders
@jimbo
Specification
Verification Steps
pwa-devdocsdirectorynpm run lint src/tutorials/create-tag-list-component/index.mdnpm run deployScreenshots / Screen Captures (if appropriate)
Checklist