[chore]: Fixing Prettier use #1941
Conversation
sirugh
added
version: Major
sirugh
force-pushed
the
rugh/remove_prettier-check
branch
from
7b0fcb0
to
f4d054a
Compare
|
| singleQuote: true | ||
| }; | ||
|
|
||
| module.exports = config; |
There was a problem hiding this comment.
Should this file be located in the pwa-studio root?
Edit: there's already one there. Does venia-concept not inherit it?
There was a problem hiding this comment.
Just to put context in this convo for later -- my intent was that venia-concept, when used as the root "theme" from the scaffolding script, would provide this config. I wasn't sure if the scaffolding script already did that work and copied the one in the root folder. If that is the case, then I can delete this file.
There was a problem hiding this comment.
This is the right move. Keeping these two files in sync shouldn't be a big problem, because they should VERY rarely change.
|
Good question. My intent was to apply the prettier config that would be copied with venia concept and one that is simple and easy to override and modify. We don't make changes often within venia-concept. This just another template file, basically.
|
|
I'll defer to @zetlen on this one. Looks fine to me. |
| singleQuote: true | ||
| }; | ||
|
|
||
| module.exports = config; |
There was a problem hiding this comment.
This is the right move. Keeping these two files in sync shouldn't be a big problem, because they should VERY rarely change.
|
Oh, @sirugh please open a dummy issue against this and link it so it passes Danger. |
Description
Removes unnecessary
prettier-checkdependency and modifies pre-push to useprettier:checkinstead ofprettier:validate.Creates a
prettier.config.jsfile and uses the config version of--single-quote. I think this is a better experience for developers for future configuration on top of venia-concept.Related Issue
Closes PWA-89.
Acceptance
Verification Stakeholders
@zetlen - I'd like to know if there are any additional changes necessary in
venia-conceptor in the scaffolding scripts.Specification
Verification Steps
venia-conceptthat would fail prettier like adding double quotes to an import. Make sure you have "format on save" off so that it doesn't auto fix.yarn prettier:checkfrom the root directory. It should complain.packages/venia-conceptand runyarn prettier. It should also complain.Screenshots / Screen Captures (if appropriate)
Checklist