Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] Refactor site content navigation #1933

Merged
merged 4 commits into from
Oct 31, 2019

Conversation

jcalcaben
Copy link
Contributor

Description

This PR refactors the doc site navigation lists to improve content discovery and separate the different types of docs (i.e. conceptual, tutorials, and reference).

Related Issue

None

Acceptance

@awilcoxa

Verification Stakeholders

@awilcoxa

Verification Steps

  1. Navigate to the docs directory: cd pwa-devdocs
  2. Remove any existing _site directory: rm -fr _site
  3. Build the HTML preview site: npm run develop
  4. Verify new top navigation
  5. Verify Getting Started and Reference API nav items have a dropdown to more specific items
  6. Click through the various items on the top nav
  7. Verify items have new left navigation contents and the entry scrolls into view

Screenshots / Screen Captures (if appropriate)

Checklist

  • I have updated the documentation accordingly, if necessary.
  • I have added tests to cover my changes, if necessary.

@jcalcaben jcalcaben added pkg:pwa-devdocs documentation This pertains to documentation. version: Patch This changeset includes backwards compatible bug fixes. docs documentation labels Oct 23, 2019
@PWAStudioBot
Copy link
Contributor

PWAStudioBot commented Oct 23, 2019

Fails
🚫

No linked issue found. Please link a relevant open issue by adding the text "closes #<issue_number>" or including the associated JIRA ID in your PR.

Messages
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).

Generated by 🚫 dangerJS against 38d4892

@dpatil-magento dpatil-magento merged commit 90fa5a1 into develop Oct 31, 2019
@dpatil-magento dpatil-magento deleted the jimothy/content-rearchitecture branch October 31, 2019 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs documentation documentation This pertains to documentation. pkg:pwa-devdocs version: Patch This changeset includes backwards compatible bug fixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants