Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed duplicate words from sentences. #1893

Merged
merged 3 commits into from
Oct 16, 2019

Conversation

sanganinamrata
Copy link
Member

@sanganinamrata sanganinamrata commented Oct 15, 2019

Description

This pull request is to remove unnecessary duplicate words in a couple of pages.

@PWAStudioBot PWAStudioBot added pkg:pwa-buildpack pkg:upward-spec Pertains to UPWARD specification package. labels Oct 15, 2019
@PWAStudioBot
Copy link
Contributor

PWAStudioBot commented Oct 15, 2019

Fails
🚫 Missing "Verification Steps" section. Please add it back, with detail.
🚫

No linked issue found. Please link a relevant open issue by adding the text "closes #<issue_number>" or including the associated JIRA ID in your PR.

🚫 A version label is required. A maintainer must add one.
Messages
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).

If your PR is missing information, check against the original template here. At a minimum you must have the section headers from the template and provide some information in each section.

Generated by 🚫 dangerJS against fa929d9

Copy link
Contributor

@supernova-at supernova-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I've commented on one that doesn't need to be changed (even though the word is duplicated).

Once you remove that from the change set I'll approve 👍

@@ -52,7 +52,7 @@ const PWADevServer = {
server.middleware.waitUntilValid(() => {
// We can try to set the hostname and port for the dev
// server all we want, but the only reliable way to know
// what it is is to detect it once it's mounted and
// what it is to detect it once it's mounted and
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one actually doesn't need to be changed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@supernova-at Done :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:pwa-buildpack pkg:upward-spec Pertains to UPWARD specification package.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants