Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the opposite operator #1851

Merged
merged 2 commits into from
Oct 7, 2019
Merged

Use the opposite operator #1851

merged 2 commits into from
Oct 7, 2019

Conversation

DanielRuf
Copy link
Contributor

Description

This PR changes the boolean check to the shorter and better opposite operator.

Related Issue

Closes #ISSUE_NUMBER.

Acceptance

Verification Stakeholders

Specification

Verification Steps

Screenshots / Screen Captures (if appropriate)

Checklist

  • I have updated the documentation accordingly, if necessary.
  • I have added tests to cover my changes, if necessary.

@PWAStudioBot
Copy link
Contributor

PWAStudioBot commented Oct 5, 2019 •
edited
Loading

Fails
🚫

No linked issue found. Please link a relevant open issue by adding the text "closes #<issue_number>" or including the associated JIRA ID in your PR.
Messages
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.
📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).

Generated by 🚫 dangerJS against d5f9328

@sirugh sirugh added the version: Patch This changeset includes backwards compatible bug fixes. label Oct 6, 2019
@dpatil-magento dpatil-magento merged commit 819cd14 into magento:develop Oct 7, 2019
@DanielRuf DanielRuf deleted the use-opposite-operator branch October 7, 2019 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimbo jimbo jimbo approved these changes

@sirugh sirugh sirugh approved these changes

Assignees

@sirugh sirugh

@jimbo jimbo

Labels
pkg:peregrine version: Patch This changeset includes backwards compatible bug fixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@DanielRuf @PWAStudioBot @sirugh @jimbo @dpatil-magento