-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor header components and add talons #1793
Conversation
@@ -32,13 +32,6 @@ | |||
padding: 0 1rem; | |||
} | |||
|
|||
.navTrigger, | |||
.cartTrigger { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unused classes.
</SearchTrigger> | ||
<CartTrigger {...cartTriggerProps} /> | ||
active={searchOpen} | ||
onClick={handleSearchTriggerClick} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Renamed props and included SearchIcon
directly in the trigger component.
If your PR is missing information, check against the original template here. At a minimum you must have the section headers from the template and provide some information in each section. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done all around. 👍
This PR is largely a refactor of header with some moving of code to talons.
Header/
directory as it didn't make sense as a standalone component.cartTrigger
so that they can more easily be used independently of theHeader
at a later time.cartCounter
as it was a with minimal styling.