Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CreateAccount and CreateAccountPage talon #1778

Merged
merged 5 commits into from
Oct 1, 2019
Merged

CreateAccount and CreateAccountPage talon #1778

merged 5 commits into from
Oct 1, 2019

Conversation

sirugh
Copy link
Contributor

@sirugh sirugh commented Sep 25, 2019 •
edited
Loading

CreateAccount and CreateAccountPage talons

@PWAStudioBot
Copy link
Contributor

PWAStudioBot commented Sep 25, 2019 •
edited
Loading

Fails
🚫 Missing "Description" section. Please add it back, with detail.
🚫 Missing "Verification Steps" section. Please add it back, with detail.
🚫

No linked issue found. Please link a relevant open issue by adding the text "closes #<issue_number>" or including the associated JIRA ID in your PR.
Messages
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.
📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).

If your PR is missing information, check against the original template here. At a minimum you must have the section headers from the template and provide some information in each section.

Generated by 🚫 dangerJS against 0c172ed

@sirugh sirugh added the version: Patch This changeset includes backwards compatible bug fixes. label Sep 25, 2019
@sirugh sirugh changed the title CreateAccount talon CreateAccount and CreateAccountPage talon Sep 25, 2019
@supernova-at supernova-at self-assigned this Oct 1, 2019
supernova-at
supernova-at requested changes Oct 1, 2019
View reviewed changes
Copy link
Contributor

@supernova-at supernova-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick fix then 👍

packages/venia-ui/lib/components/CreateAccountPage/createAccountPage.js Outdated Show resolved Hide resolved
@dpatil-magento dpatil-magento merged commit 8c645c7 into develop Oct 1, 2019
@dpatil-magento dpatil-magento deleted the rugh/talon-createaccount branch October 1, 2019 17:12
This was referenced Oct 2, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@supernova-at supernova-at supernova-at approved these changes

Assignees

@sirugh sirugh

@supernova-at supernova-at

Labels
pkg:peregrine pkg:venia-ui version: Patch This changeset includes backwards compatible bug fixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sirugh @PWAStudioBot @supernova-at @dpatil-magento