Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create categoryTile/categoryList talon #1755

Merged
merged 14 commits into from
Sep 26, 2019
Merged

Conversation

sirugh
Copy link
Contributor

@sirugh sirugh commented Sep 23, 2019

Refactor of categoryList and categoryTile to function component along with their...talons.

Requires a full review plz.

@PWAStudioBot
Copy link
Contributor

PWAStudioBot commented Sep 23, 2019

Fails
🚫 Missing "Description" section. Please add it back, with detail.
🚫 Missing "Verification Steps" section. Please add it back, with detail.
🚫

No linked issue found. Please link a relevant open issue by adding the text "closes #<issue_number>" or including the associated JIRA ID in your PR.

Messages
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).

If your PR is missing information, check against the original template here. At a minimum you must have the section headers from the template and provide some information in each section.

Generated by 🚫 dangerJS against ab95f00

@sirugh sirugh changed the title Create categoryTile mixin and move makeurl to peregrine Create categoryTile/categoryList talon Sep 23, 2019
@sirugh sirugh marked this pull request as ready for review September 24, 2019 14:11
@sirugh sirugh added the version: Patch This changeset includes backwards compatible bug fixes. label Sep 24, 2019
</div>
) : null;
}
const { data, error, loading } = mixinProps;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could probably make this simpler by just returning the error and the normalized data, categoryChildren.

jimbo
jimbo previously approved these changes Sep 26, 2019
* @param {object} props
* @param {object} props.query - category data
* @param {string} props.id - category id
* @return {{ data: object, error: boolean, loading: boolean }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is error a boolean or an Error object?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll look and see how we're using it in categoryList and update the output accordingly.

error,
loading
childCategories:
Copy link
Contributor

@jimbo jimbo Sep 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good change, in line with your other comment. Stylistically, I do think you should do calculations outside of the return block, but it's not a big deal.

Also I think we should still return loading, since a well-designed component would use it.

@sirugh sirugh merged commit 0a6335e into develop Sep 26, 2019
@sirugh sirugh deleted the rugh/mixin-categoryList branch September 26, 2019 18:58
@jimbo jimbo mentioned this pull request Oct 2, 2019
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:peregrine pkg:venia-ui version: Patch This changeset includes backwards compatible bug fixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants